From: Philipp Rudo Date: Tue, 11 Apr 2017 13:28:51 +0000 (+0100) Subject: Fix read after xfree in linux-nat.c:linux_nat_detach X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a6acac06113f4b04fa0333ee2a3ab3025b43ee7c;p=binutils-gdb.git Fix read after xfree in linux-nat.c:linux_nat_detach At the end of linux_nat_detach the main_lwp is deleted (delete_lwp). This is problematic as during detach (detach_one_lwp and linux_fork_detach) main_lwp already gets freed. Thus calling delete_lwp causes a read after free. Fix it by removing the unnecessary delete_lwp. gdb/ChangeLog: 2017-04-11 Philipp Rudo * linux-nat.c (linux_nat_detach): Remove delete_lwp call. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dc3393a27f6..60e03e76198 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-04-11 Philipp Rudo + + * linux-nat.c (linux_nat_detach): Remove delete_lwp call. + 2017-04-11 Alan Hayward * arm-tdep.c (arm_store_return_value): Use FP_REGISTER_SIZE diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index b06e400fdc2..8dececf2c52 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -1549,7 +1549,6 @@ linux_nat_detach (struct target_ops *ops, const char *args, int from_tty) inf_ptrace_detach_success (ops); } - delete_lwp (main_lwp->ptid); } /* Resume execution of the inferior process. If STEP is nonzero,