From: Alan Hayward Date: Tue, 14 May 2019 09:09:05 +0000 (+0100) Subject: AArch64: Add half float view to V registers X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a6d0f2490c0c7969eb60038f01c0ee0f46e4d5fd;p=binutils-gdb.git AArch64: Add half float view to V registers AArch64 can fill the vector registers with half precision floats. Add a view for this. Add builtin type ieee half and connect this to the existing floatformats_ieee_half. gdb/ChangeLog: 2019-05-14 Alan Hayward * aarch64-tdep.c (aarch64_vnh_type): Add half view. (aarch64_vnv_type): Likewise. * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF. * common/tdesc.c: Likewise. * common/tdesc.h (enum tdesc_type_kind): Likewise. * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate. * features/aarch64-fpu.xml: Add ieee half view. * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise. * gdbtypes.c (gdbtypes_post_init): Add builtin_half * gdbtypes.h (struct builtin_type): Likewise. (struct objfile_type): Likewise. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 19458ccc726..44646f50d5b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,17 @@ +2019-05-14 Alan Hayward + + * aarch64-tdep.c (aarch64_vnh_type): Add half view. + (aarch64_vnv_type): Likewise. + * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF. + * common/tdesc.c: Likewise. + * common/tdesc.h (enum tdesc_type_kind): Likewise. + * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate. + * features/aarch64-fpu.xml: Add ieee half view. + * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise. + * gdbtypes.c (gdbtypes_post_init): Add builtin_half + * gdbtypes.h (struct builtin_type): Likewise. + (struct objfile_type): Likewise. + 2019-05-12 Paul Naert * language.c (language_sniff_from_mangled_name): Fix "langauge" diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 2c8c6a1bdc3..bbb2a25f956 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -1885,6 +1885,9 @@ aarch64_vnh_type (struct gdbarch *gdbarch) t = arch_composite_type (gdbarch, "__gdb_builtin_type_vnh", TYPE_CODE_UNION); + elem = builtin_type (gdbarch)->builtin_half; + append_composite_type_field (t, "f", elem); + elem = builtin_type (gdbarch)->builtin_uint16; append_composite_type_field (t, "u", elem); @@ -1963,6 +1966,8 @@ aarch64_vnv_type (struct gdbarch *gdbarch) sub = arch_composite_type (gdbarch, "__gdb_builtin_type_vnh", TYPE_CODE_UNION); + append_composite_type_field (sub, "f", + init_vector_type (bt->builtin_half, 8)); append_composite_type_field (sub, "u", init_vector_type (bt->builtin_uint16, 8)); append_composite_type_field (sub, "s", diff --git a/gdb/common/tdesc.c b/gdb/common/tdesc.c index fe63a36c339..f946a53c7f3 100644 --- a/gdb/common/tdesc.c +++ b/gdb/common/tdesc.c @@ -50,6 +50,7 @@ static tdesc_type_builtin tdesc_predefined_types[] = { "uint128", TDESC_TYPE_UINT128 }, { "code_ptr", TDESC_TYPE_CODE_PTR }, { "data_ptr", TDESC_TYPE_DATA_PTR }, + { "ieee_half", TDESC_TYPE_IEEE_HALF }, { "ieee_single", TDESC_TYPE_IEEE_SINGLE }, { "ieee_double", TDESC_TYPE_IEEE_DOUBLE }, { "arm_fpa_ext", TDESC_TYPE_ARM_FPA_EXT }, diff --git a/gdb/common/tdesc.h b/gdb/common/tdesc.h index a0bc6339e26..9eb3d5ea312 100644 --- a/gdb/common/tdesc.h +++ b/gdb/common/tdesc.h @@ -147,6 +147,7 @@ enum tdesc_type_kind TDESC_TYPE_UINT128, TDESC_TYPE_CODE_PTR, TDESC_TYPE_DATA_PTR, + TDESC_TYPE_IEEE_HALF, TDESC_TYPE_IEEE_SINGLE, TDESC_TYPE_IEEE_DOUBLE, TDESC_TYPE_ARM_FPA_EXT, diff --git a/gdb/features/aarch64-fpu.c b/gdb/features/aarch64-fpu.c index 47962d1f242..b73d12ebe48 100644 --- a/gdb/features/aarch64-fpu.c +++ b/gdb/features/aarch64-fpu.c @@ -28,6 +28,9 @@ create_feature_aarch64_fpu (struct target_desc *result, long regnum) element_type = tdesc_named_type (feature, "int32"); tdesc_create_vector (feature, "v4i", element_type, 4); + element_type = tdesc_named_type (feature, "ieee_half"); + tdesc_create_vector (feature, "v8f", element_type, 8); + element_type = tdesc_named_type (feature, "uint16"); tdesc_create_vector (feature, "v8u", element_type, 8); @@ -65,6 +68,8 @@ create_feature_aarch64_fpu (struct target_desc *result, long regnum) tdesc_add_field (type_with_fields, "s", field_type); type_with_fields = tdesc_create_union (feature, "vnh"); + field_type = tdesc_named_type (feature, "v8f"); + tdesc_add_field (type_with_fields, "f", field_type); field_type = tdesc_named_type (feature, "v8u"); tdesc_add_field (type_with_fields, "u", field_type); field_type = tdesc_named_type (feature, "v8i"); diff --git a/gdb/features/aarch64-fpu.xml b/gdb/features/aarch64-fpu.xml index 141c996eadd..1eba8faea7c 100644 --- a/gdb/features/aarch64-fpu.xml +++ b/gdb/features/aarch64-fpu.xml @@ -14,6 +14,7 @@ + @@ -31,6 +32,7 @@ + diff --git a/gdb/features/aarch64-sve.c b/gdb/features/aarch64-sve.c index 2166b4bb071..ae292d2f3da 100644 --- a/gdb/features/aarch64-sve.c +++ b/gdb/features/aarch64-sve.c @@ -55,6 +55,9 @@ create_feature_aarch64_sve (struct target_desc *result, long regnum, element_type = tdesc_named_type (feature, "int32"); tdesc_create_vector (feature, "svevss", element_type, 4 * scale); + element_type = tdesc_named_type (feature, "ieee_half"); + tdesc_create_vector (feature, "svevhf", element_type, 8 * scale); + element_type = tdesc_named_type (feature, "uint16"); tdesc_create_vector (feature, "svevhu", element_type, 8 * scale); @@ -90,6 +93,8 @@ create_feature_aarch64_sve (struct target_desc *result, long regnum, tdesc_add_field (type_with_fields, "s", field_type); type_with_fields = tdesc_create_union (feature, "svevnh"); + field_type = tdesc_named_type (feature, "svevhf"); + tdesc_add_field (type_with_fields, "f", field_type); field_type = tdesc_named_type (feature, "svevhu"); tdesc_add_field (type_with_fields, "u", field_type); field_type = tdesc_named_type (feature, "svevhs"); diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 59456f9f3a4..e329adc368e 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -5359,6 +5359,9 @@ gdbtypes_post_init (struct gdbarch *gdbarch) builtin_type->builtin_unsigned_long_long = arch_integer_type (gdbarch, gdbarch_long_long_bit (gdbarch), 1, "unsigned long long"); + builtin_type->builtin_half + = arch_float_type (gdbarch, gdbarch_half_bit (gdbarch), + "half", gdbarch_half_format (gdbarch)); builtin_type->builtin_float = arch_float_type (gdbarch, gdbarch_float_bit (gdbarch), "float", gdbarch_float_format (gdbarch)); diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index edea6f05474..2f3834e9f56 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -1595,6 +1595,7 @@ struct builtin_type struct type *builtin_unsigned_short; struct type *builtin_unsigned_int; struct type *builtin_unsigned_long; + struct type *builtin_half; struct type *builtin_float; struct type *builtin_double; struct type *builtin_long_double; @@ -1690,6 +1691,7 @@ struct objfile_type struct type *builtin_unsigned_int; struct type *builtin_unsigned_long; struct type *builtin_unsigned_long_long; + struct type *builtin_half; struct type *builtin_float; struct type *builtin_double; struct type *builtin_long_double; diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c index 96d453527cd..bd33091ba9e 100644 --- a/gdb/target-descriptions.c +++ b/gdb/target-descriptions.c @@ -119,6 +119,11 @@ make_gdb_type (struct gdbarch *gdbarch, struct tdesc_type *ttype) switch (e->kind) { + case TDESC_TYPE_IEEE_HALF: + m_type = arch_float_type (m_gdbarch, -1, "builtin_type_ieee_half", + floatformats_ieee_half); + return; + case TDESC_TYPE_IEEE_SINGLE: m_type = arch_float_type (m_gdbarch, -1, "builtin_type_ieee_single", floatformats_ieee_single);