From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Thu, 2 Dec 2021 19:12:44 +0000 (-0500)
Subject: gdb: remove unexpected xstrdup in _initialize_maint_test_settings
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a6ea2592a983a67f7c537fb97eab7c9e9ba675c7;p=binutils-gdb.git

gdb: remove unexpected xstrdup in _initialize_maint_test_settings

That xstrdup is not correct, since we are assigning an std::string.  The
result of xstrdup is used to initialize the string, and then lost
forever.  Remove it.

Change-Id: Ief7771055e4bfd643ef3b285ec9fb7b1bfd14335
---

diff --git a/gdb/maint-test-settings.c b/gdb/maint-test-settings.c
index 9f50088833a..ae61caa0391 100644
--- a/gdb/maint-test-settings.c
+++ b/gdb/maint-test-settings.c
@@ -83,7 +83,7 @@ void _initialize_maint_test_settings ();
 void
 _initialize_maint_test_settings ()
 {
-  maintenance_test_settings_filename = xstrdup ("/foo/bar");
+  maintenance_test_settings_filename = "/foo/bar";
 
   add_setshow_prefix_cmd ("test-settings", class_maintenance,
 			  _("\