From: Jose Maria Casanova Crespo Date: Thu, 28 Jun 2018 13:36:12 +0000 (+0200) Subject: anv: finish the binding_table_pool on destroyDevice when use_softpin X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a99c9e63a07477634ab73945e5da5b9f580e5828;p=mesa.git anv: finish the binding_table_pool on destroyDevice when use_softpin Running VK-CTS in batch execution mode was raising the VK_ERROR_INITIALIZATION_FAILED error in multiple tests. But when the same failing tests were run isolated they always passed. createDevice and destroyDevice were called before and after every tests. Because the binding_table_pool was never closed, we reached the maximum number of open file descriptors (ulimit -n) and when that happened every call to createDevice implied a VK_ERROR_INITIALIZATION_FAILED error. Fixes: c7db0ed4e94dce563d722e1b098684fbd7315d51 ("anv: Use a separate pool for binding tables when soft pinning") Reviewed-by: Jason Ekstrand --- diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index b3d30675b1e..cc319f09018 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -1771,6 +1771,7 @@ void anv_DestroyDevice( const VkAllocationCallbacks* pAllocator) { ANV_FROM_HANDLE(anv_device, device, _device); + struct anv_physical_device *physical_device = &device->instance->physicalDevice; if (!device) return; @@ -1797,6 +1798,8 @@ void anv_DestroyDevice( if (device->info.gen >= 10) anv_gem_close(device, device->hiz_clear_bo.gem_handle); + if (physical_device->use_softpin) + anv_state_pool_finish(&device->binding_table_pool); anv_state_pool_finish(&device->surface_state_pool); anv_state_pool_finish(&device->instruction_state_pool); anv_state_pool_finish(&device->dynamic_state_pool);