From: Doug Evans <dje@google.com>
Date: Tue, 15 Mar 2016 19:44:34 +0000 (-0700)
Subject: Remove hand-called function from test.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=aa52b601cc232d41a956c9929a090f077c6d1a4a;p=binutils-gdb.git

Remove hand-called function from test.

gdb/testsuite/ChangeLog:

	* gdb.base/skip.c (main): Call test_skip_file_and_function.
	* gdb.base/skip.exp: Remove hand calling test_skip_file_and_function.
---

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index eec8604b143..177b2d1af94 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-15  Doug Evans  <dje@google.com>
+
+	* gdb.base/skip.c (main): Call test_skip_file_and_function.
+	* gdb.base/skip.exp: Remove hand calling test_skip_file_and_function.
+
 2016-03-14  Simon Marchi  <simon.marchi@ericsson.com>
 
 	* gdb.base/default.exp: Add $_as_string to the list of expected
diff --git a/gdb/testsuite/gdb.base/skip.c b/gdb/testsuite/gdb.base/skip.c
index b9db2a78986..576f2ab8320 100644
--- a/gdb/testsuite/gdb.base/skip.c
+++ b/gdb/testsuite/gdb.base/skip.c
@@ -21,12 +21,19 @@ int foo (void);
 int bar (void);
 int baz (int);
 void skip1_test_skip_file_and_function (void);
+void test_skip_file_and_function (void);
 
 int
 main ()
 {
+  int x;
+
   /* Use comma operator to sequence evaluation of bar and foo.  */
-  return baz ((bar (), foo ()));
+  x = baz ((bar (), foo ()));
+
+  test_skip_file_and_function ();
+
+  return 0;
 }
 
 int
diff --git a/gdb/testsuite/gdb.base/skip.exp b/gdb/testsuite/gdb.base/skip.exp
index 67ae9d9ac85..ce55dd28d34 100644
--- a/gdb/testsuite/gdb.base/skip.exp
+++ b/gdb/testsuite/gdb.base/skip.exp
@@ -281,17 +281,15 @@ with_test_prefix "step using -rfu for baz" {
 # Test -fi + -fu.
 
 with_test_prefix "step using -fi + -fu" {
-    if ![runto_main] {
-	fail "Can't run to main"
+    gdb_test_no_output "skip delete"
+
+    if ![runto test_skip_file_and_function no-message] {
+	fail "Can't run to test_skip_file_and_function"
 	return
     }
 
-    gdb_test_no_output "skip delete"
     gdb_test "skip -fi skip1.c -fu test_skip" \
 	"Function test_skip in file skip1.c will be skipped when stepping\."
-    gdb_breakpoint "test_skip_file_and_function"
-    gdb_breakpoint "end_test_skip_file_and_function"
-    gdb_test "call test_skip_file_and_function ()" "silently stop."
     # Verify we can step into skip.c:test_skip but not skip1.c:test_skip.
     gdb_test "step" "test_skip \\(\\) at.*" "step 1"
     gdb_test "step" "test_skip_file_and_function \\(\\) at.*" "step 2"; # Return from test_skip()