From: Lisa Hsu <Lisa.Hsu@amd.com>
Date: Wed, 9 Jun 2010 17:47:37 +0000 (-0700)
Subject: flags: add comment to avoid future deletions since code appears redundant.
X-Git-Tag: stable_2012_02_02~1041
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=aa7888797032bab49b5f0f637c859740497423d8;p=gem5.git

flags: add comment to avoid future deletions since code appears redundant.
---

diff --git a/src/sim/eventq.cc b/src/sim/eventq.cc
index 900a6dd4b..d46061064 100644
--- a/src/sim/eventq.cc
+++ b/src/sim/eventq.cc
@@ -233,15 +233,22 @@ Event::unserialize(Checkpoint *cp, const string &section)
     UNSERIALIZE_SCALAR(_when);
     UNSERIALIZE_SCALAR(_priority);
 
-    // need to see if original event was in a scheduled, unsquashed
-    // state, but don't want to restore those flags in the current
-    // object itself (since they aren't immediately true)
     short _flags;
     UNSERIALIZE_SCALAR(_flags);
+
+    // Old checkpoints had no concept of the Initialized flag
+    // so restoring from old checkpoints always fail.
+    // Events are initialized on construction but original code 
+    // "flags = _flags" would just overwrite the initialization. 
+    // So, read in the checkpoint flags, but then set the Initialized 
+    // flag on top of it in order to avoid failures.
     assert(initialized());
     flags = _flags;
     flags.set(Initialized);
 
+    // need to see if original event was in a scheduled, unsquashed
+    // state, but don't want to restore those flags in the current
+    // object itself (since they aren't immediately true)
     bool wasScheduled = flags.isSet(Scheduled) && !flags.isSet(Squashed);
     flags.clear(Squashed | Scheduled);