From: Simon Marchi <simon.marchi@efficios.com>
Date: Mon, 27 Feb 2023 01:13:54 +0000 (-0500)
Subject: gdb: remove invalid / dead code from gdbarch.py
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=aa992b382f91f426cd51bf1375d78eacb509f2cc;p=binutils-gdb.git

gdb: remove invalid / dead code from gdbarch.py

My editor flagged that the variable `c` (in the lines removed by this
patch) was unknown.  I guess it ends up working because there is a `c`
variable in the global scope.  I tried putting `assert False` inside
that if, and it is not hit, showing that we never enter this if.  So,
remove it.  There is no change in the generated files.

Change-Id: Id3b9f67719e88cada7c6fde673c8d7842ab13617
Reviewed-By: Tom Tromey <tom@tromey.com>
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
---

diff --git a/gdb/gdbarch.py b/gdb/gdbarch.py
index 3ebc3598047..68c7bbae661 100755
--- a/gdb/gdbarch.py
+++ b/gdb/gdbarch.py
@@ -64,8 +64,6 @@ class _Component:
         assert self.predicate and not isinstance(self.invalid, str)
         if self.predefault:
             predicate = f"gdbarch->{self.name} != {self.predefault}"
-        elif isinstance(c, Value):
-            predicate = f"gdbarch->{self.name} != 0"
         else:
             predicate = f"gdbarch->{self.name} != NULL"
         return predicate