From: Ciro Santilli <ciro.santilli@arm.com>
Date: Tue, 6 Aug 2019 15:17:51 +0000 (+0100)
Subject: base: assert that stats bucket size is greater than 0
X-Git-Tag: v19.0.0.0~644
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=acad54cf4e01809170e343b13f302fc5b032c366;p=gem5.git

base: assert that stats bucket size is greater than 0

Change-Id: I9a2264e9ee74acea1f09f01ea8f5004567ba1ea8
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/20049
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Anthony Gutierrez <anthony.gutierrez@amd.com>
Maintainer: Anthony Gutierrez <anthony.gutierrez@amd.com>
Tested-by: kokoro <noreply+kokoro@google.com>
---

diff --git a/src/base/statistics.hh b/src/base/statistics.hh
index 69a2afffc..6ddf7ff17 100644
--- a/src/base/statistics.hh
+++ b/src/base/statistics.hh
@@ -2533,6 +2533,9 @@ class Distribution : public DistBase<Distribution, DistStor>
         params->min = min;
         params->max = max;
         params->bucket_size = bkt;
+        // Division by zero is especially serious in an Aarch64 host,
+        // where it gets rounded to allocate 32GiB RAM.
+        assert(bkt > 0);
         params->buckets = (size_type)ceil((max - min + 1.0) / bkt);
         this->setParams(params);
         this->doInit();