From: Andrew Burgess <aburgess@broadcom.com>
Date: Mon, 8 Jul 2013 10:21:33 +0000 (+0000)
Subject: Fix bug in value_bits_valid.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ad0f030310315704eeb4651460edb548fad21a02;p=binutils-gdb.git

Fix bug in value_bits_valid.

http://sourceware.org/ml/gdb-patches/2013-07/msg00174.html

	* value.c (value_bits_valid): If the value is not lval_computed
	or has no check validity handler then the answer is the
	optimized_out flag, otherwise defer to the handler.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 09d5aac2f9e..fad36f45517 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2013-07-08  Andrew Burgess  <aburgess@broadcom.com>
+            Pedro Alves  <palves@redhat.com>
+
+	* value.c (value_bits_valid): If the value is not lval_computed
+	or has no check validity handler then the answer is the
+	optimized_out flag, otherwise defer to the handler.
+
 2013-07-06  Eli Zaretskii  <eliz@gnu.org>
 
 	* top.c (print_gdb_configuration): Explain in output of
diff --git a/gdb/value.c b/gdb/value.c
index 353f62a2caa..1be18456574 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -1082,13 +1082,12 @@ value_entirely_optimized_out (const struct value *value)
 int
 value_bits_valid (const struct value *value, int offset, int length)
 {
-  if (!value->optimized_out)
-    return 1;
   if (value->lval != lval_computed
       || !value->location.computed.funcs->check_validity)
-    return 1;
-  return value->location.computed.funcs->check_validity (value, offset,
-							 length);
+    return !value->optimized_out;
+  else
+    return value->location.computed.funcs->check_validity (value, offset,
+							   length);
 }
 
 int