From: Nick Alcock <nick.alcock@oracle.com>
Date: Tue, 17 Sep 2019 05:59:31 +0000 (+0100)
Subject: libctf: fix refcount leak in ctf_import
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ad613f1d0693e02bdc86047c479315d5f969e2f7;p=binutils-gdb.git

libctf: fix refcount leak in ctf_import

Calling ctf_import (fp, NULL) to cancel out a pre-existing import leaked
the refcnt increment on the parent, so it could never be freed.

New in v4.

libctf/
	* ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
	ctf_import after the first for a given file.
---

diff --git a/libctf/ChangeLog b/libctf/ChangeLog
index b7f12d8e092..982c3355699 100644
--- a/libctf/ChangeLog
+++ b/libctf/ChangeLog
@@ -1,3 +1,8 @@
+2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
+
+	* ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
+	ctf_import after the first for a given file.
+
 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 
 	* ctf-impl.h (ctf_str_append_noerr): Declare.
diff --git a/libctf/ctf-open.c b/libctf/ctf-open.c
index 4a95b7f38a5..aedf39086a2 100644
--- a/libctf/ctf-open.c
+++ b/libctf/ctf-open.c
@@ -1778,6 +1778,7 @@ ctf_import (ctf_file_t *fp, ctf_file_t *pfp)
 
   if (fp->ctf_parent != NULL)
     {
+      fp->ctf_parent->ctf_refcnt--;
       ctf_file_close (fp->ctf_parent);
       fp->ctf_parent = NULL;
     }
@@ -1793,6 +1794,7 @@ ctf_import (ctf_file_t *fp, ctf_file_t *pfp)
       fp->ctf_flags |= LCTF_CHILD;
       pfp->ctf_refcnt++;
     }
+
   fp->ctf_parent = pfp;
   return 0;
 }