From: Aaron Plattner Date: Thu, 22 Apr 2010 16:30:42 +0000 (-0700) Subject: Fix __glXInitializeVisualConfigFromTags's handling of unrecognized fbconfig tags. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ad7d36e91933a49ce3f6ed2c14ae585a8a84fdf5;p=mesa.git Fix __glXInitializeVisualConfigFromTags's handling of unrecognized fbconfig tags. __glXInitializeVisualConfigFromTags doesn't skip the payload of unrecognized tags. Instead, it treats the value as if it were the next tag, which can happen if the server's GLX extension is not Mesa's. For example, this falls down when NVIDIA sends a GLX_FLOAT_COMPONENTS_NV = 0 pair, causing __glXInitializeVisualConfigFromTags to bail out early. Signed-off-by: Aaron Plattner Signed-off-by: Ian Romanick --- diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 5289354a521..6d6f89e79a2 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -539,6 +539,8 @@ __glXInitializeVisualConfigFromTags(__GLcontextModes * config, int count, i = count; break; default: + /* Ignore the unrecognized tag's value */ + bp++; break; } }