From: Emil Velikov Date: Fri, 13 Jan 2017 17:27:56 +0000 (+0000) Subject: egl/wayland: resolve quirky try_damage_buffer() implementation X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=af4a298719e7b70cae6592c923ffbed9d4dc3678;p=mesa.git egl/wayland: resolve quirky try_damage_buffer() implementation The implementation was added with commit d085a5dff5b and effectively provided a hidden dependency. Namely: the codepath used was determined solely during build time. Thus if we built again new wayland and then run against older (yet still within the requirements, as per the configure) one will get undefined symbols. As of earlier commit 36b9976e1f9 "egl/wayland: Avoid race conditions when on non-main thread" the required version was bumped to one which provides the API, thus we can drop the quirky solution. Cc: Derek Foreman Signed-off-by: Emil Velikov Reviewed-by: Daniel Stone Reviewed-by: Derek Foreman --- diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 43b62c6dca5..37360c7f7eb 100644 --- a/src/egl/drivers/dri2/platform_wayland.c +++ b/src/egl/drivers/dri2/platform_wayland.c @@ -658,14 +658,6 @@ try_damage_buffer(struct dri2_egl_surface *dri2_surf, const EGLint *rects, EGLint n_rects) { -/* The WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION macro and - * wl_proxy_get_version() were both introduced in wayland 1.10. - * Instead of bumping our wayland dependency we just make this - * function conditional on the required 1.10 features, falling - * back to old (correct but suboptimal) behaviour for older - * wayland. - */ -#ifdef WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION int i; if (wl_proxy_get_version((struct wl_proxy *) dri2_surf->wl_win->surface) @@ -681,8 +673,6 @@ try_damage_buffer(struct dri2_egl_surface *dri2_surf, rect[2], rect[3]); } return EGL_TRUE; -#endif - return EGL_FALSE; } /** * Called via eglSwapBuffers(), drv->API.SwapBuffers().