From: Alex Smith Date: Fri, 21 Jul 2017 16:00:00 +0000 (+0100) Subject: radv: Generate storage image descriptors unconditionally X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=af9d6a8a99fa67bade628028b7265ae21445a930;p=mesa.git radv: Generate storage image descriptors unconditionally We can also use storage images internally for resolves, which don't require TRANSFER_DST usage on the image, so currently we may not create the needed descriptors. Just create these descriptors unconditionally. Fixes: 0e1886efb9e ("radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT") Reported-by: Grazvydas Ignotas Signed-off-by: Alex Smith Signed-off-by: Dave Airlie --- diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index f5fb790ddaf..d8b7e8f421f 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -945,10 +945,7 @@ radv_image_view_init(struct radv_image_view *iview, iview->base_mip = range->baseMipLevel; radv_image_view_make_descriptor(iview, device, pCreateInfo, false); - - /* For transfers we may use the image as a storage image. */ - if (image->usage & (VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT)) - radv_image_view_make_descriptor(iview, device, pCreateInfo, true); + radv_image_view_make_descriptor(iview, device, pCreateInfo, true); } bool radv_layout_has_htile(const struct radv_image *image,