From: Michael Forney <mforney@mforney.org>
Date: Wed, 10 Apr 2019 08:47:37 +0000 (+0930)
Subject: PR24427, bfd/doc/chew.c reads uninitialized memory and subtracts from function pointer
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b05971a652c35ed72d3c95290e18d8f6e4ef6c46;p=binutils-gdb.git

PR24427, bfd/doc/chew.c reads uninitialized memory and subtracts from function pointer

	PR 24427
	* doc/chew.c (free_words): Correctly free "push_text" strings.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 6e85dc797bd..03cab045da6 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2019-04-10  Michael Forney  <mforney@mforney.org>
+
+	PR 24427
+	* doc/chew.c (free_words): Correctly free "push_text" strings.
+
 2019-04-08  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* config.bfd: Remove i[3-7]86-*-kaos* and i[3-7]86-*-chaos targets.
diff --git a/bfd/doc/chew.c b/bfd/doc/chew.c
index c3dd9b444bf..ef5a22c2fa5 100644
--- a/bfd/doc/chew.c
+++ b/bfd/doc/chew.c
@@ -1260,11 +1260,11 @@ free_words (void)
       if (ptr->code)
 	{
 	  int i;
-	  for (i = 0; i < ptr->code_length; i ++)
+	  for (i = 0; i < ptr->code_end - 1; i ++)
 	    if (ptr->code[i] == push_text
 		&& ptr->code[i + 1])
 	      {
-		free (ptr->code[i + 1] - 1);
+		free ((char *) ptr->code[i + 1] - 1);
 		++ i;
 	      }
 	  free (ptr->code);