From: Jose Maria Casanova Crespo Date: Wed, 8 Apr 2020 18:51:52 +0000 (+0200) Subject: v3d: Primitive Counts Feedback needs an extra 32-bit padding. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b06fdb8edd9ef999ee8707335888f7609c144102;p=mesa.git v3d: Primitive Counts Feedback needs an extra 32-bit padding. Store Primitive Counts operations write 7 counters in 32-bit words but also a padding 32-bit with 0. So we need 8 32-bit words instead of the current 7 allocated. This was causing an corruption in the next buffer when Transform Feedback was enabled that were exposed on tests like: dEQP-GLES3.functional.transform_feedback.*.points.* This patch fixes 196 tests that were failing when they were run isolated but they were passing when run using cts-runner. Fixes: 0f2d1dfe65bf ("v3d: use the GPU to record primitives written to transform feedback") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2674 Reviewed-by: Alejandro Piñeiro Part-of: --- diff --git a/src/gallium/drivers/v3d/v3dx_state.c b/src/gallium/drivers/v3d/v3dx_state.c index a0bb71ca540..8e58468006c 100644 --- a/src/gallium/drivers/v3d/v3dx_state.c +++ b/src/gallium/drivers/v3d/v3dx_state.c @@ -1250,7 +1250,8 @@ v3d_set_stream_output_targets(struct pipe_context *pctx, /* Create primitive counters BO if needed */ if (num_targets > 0 && !ctx->prim_counts) { - uint32_t zeroes[7] = { 0 }; /* Init all 7 counters to 0 */ + /* Init all 7 counters and 1 padding to 0 */ + uint32_t zeroes[8] = { 0 }; u_upload_data(ctx->uploader, 0, sizeof(zeroes), 32, zeroes, &ctx->prim_counts_offset,