From: Matt Turner <mattst88@gmail.com>
Date: Mon, 16 May 2016 19:48:00 +0000 (-0700)
Subject: spirv: Properly size the src[] array.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b1e6d069daeda87cb7e14a45a0e4438cc0b399d0;p=mesa.git

spirv: Properly size the src[] array.

Operations like nir_op_bitfield_insert have four arguments, and Coverity
isn't privy to the fact that 4-argument operations aren't possible here,
so it thinks this can lead to memory corruption. Just increase the size
of the array to quell any fears.
---

diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index c65f971ad79..56948bf8a3f 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -1036,7 +1036,7 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
          unsigned bit_size =
             glsl_get_bit_size(val->const_type);
 
-         nir_const_value src[3];
+         nir_const_value src[4];
          assert(count <= 7);
          for (unsigned i = 0; i < count - 4; i++) {
             nir_constant *c =