From: Alexandra Hájková <ahajkova@redhat.com>
Date: Tue, 11 May 2021 07:47:42 +0000 (+0200)
Subject: inflow.c: Do not leak tty.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b534617fd56d260d8d6c6c40124390ce72af476a;p=binutils-gdb.git

inflow.c: Do not leak tty.

In a case open() returns 0 tty might be leaked. While 0 should be
stdin (and therefore is an unlikely return value from open()), it's
still the case that the test should be for non-negative return values
from open().

gdb/ChangeLog:

2021-05-11 Alexandra Hájková <ahajkova@redhat.com>

	* inflow.c (new_tty): Do not leak tty.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 82131c11038..4cc0cb8794f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -247,6 +247,11 @@
 	* btrace.c (handle_pt_insn_events): Ignore status update enable
 	events.
 
+2021-05-11 Alexandra Hájková <ahajkova@redhat.com>
+
+	* inflow.c (new_tty): Do not leak tty.
+
+
 2021-05-11  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* arm-tdep.c (arm_record_data_proc_misc_ld_str): Fix
diff --git a/gdb/inflow.c b/gdb/inflow.c
index 994c73e40ee..d241540c4cd 100644
--- a/gdb/inflow.c
+++ b/gdb/inflow.c
@@ -808,7 +808,7 @@ new_tty (void)
      systems (SVR4 for example), this may cause a SIGTTOU, so temporarily
      ignore SIGTTOU.  */
   tty = open ("/dev/tty", O_RDWR);
-  if (tty > 0)
+  if (tty >= 0)
     {
       scoped_ignore_sigttou ignore_sigttou;