From: Emil Velikov Date: Wed, 16 Nov 2016 11:54:54 +0000 (+0000) Subject: docs/submittingpatches: fix tags mis/abuse X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b571c075e9ab48ccbb71879861117171d2344c6b;p=mesa.git docs/submittingpatches: fix tags mis/abuse Fix the odd tag so that we're HTML 4.01 Traditional compliant Signed-off-by: Emil Velikov Reviewed-by: Brian Paul --- diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 39b615bc9af..d3e86f5b443 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -134,7 +134,7 @@ to check for regressions.

Patches should be sent to the mesa-dev mailing list for review: -mesa-dev@lists.freedesktop.org. +mesa-dev@lists.freedesktop.org. When submitting a patch make sure to use git send-email rather than attaching patches to emails. Sending patches as @@ -161,6 +161,7 @@ state of your old patches to Superseded.

When you've reviewed a patch on the mailing list, please be unambiguous about your review. That is, state either +

     Reviewed-by: Joe Hacker <jhacker@foo.com>
 
@@ -168,14 +169,17 @@ or
     Acked-by: Joe Hacker <jhacker@foo.com>
 
+

Rather than saying just "LGTM" or "Seems OK".

If small changes are suggested, it's OK to say something like: +

    With the above fixes, Reviewed-by: Joe Hacker <jhacker@foo.com>
 
+

which tells the patch author that the patch can be committed, as long as the issues are resolved first.