From: Mark Mitchell <mark@codesourcery.com>
Date: Thu, 29 Nov 2001 20:19:41 +0000 (+0000)
Subject: re PR c++/3471 (gcc 3.01 reports error about a private copy constructor that shouldn... 
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b67db52985b8ed3a7b4a32f7948b50e6bff6f6b1;p=gcc.git

re PR c++/3471 (gcc 3.01 reports error about a private copy constructor that shouldn't get called.)

	PR c++/3471
	* call.c (convert_like_real): Do not build additional temporaries
	for rvalues of class type.

From-SVN: r47451
---

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 029b0e866e5..88852450ba2 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2001-11-29  Mark Mitchell  <mark@codesourcery.com>
+
+	PR c++/3471
+	* call.c (convert_like_real): Do not build additional temporaries
+	for rvalues of class type.
+
 2001-11-28  Nathan Sidwell  <nathan@codesourcery.com>
 
 	* cp-tree.h (UNIQUELY_DERIVED_FROM_P): Use lookup base.
diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index fc1395ce5ce..e4256b6973f 100644
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -3820,7 +3820,7 @@ convert_like_real (convs, expr, fn, argnum, inner)
 
 	   If the target is a class, that means call a ctor.  */
 	if (IS_AGGR_TYPE (totype)
-	    && (inner >= 0 || !real_lvalue_p (expr)))
+	    && (inner >= 0 || !lvalue_p (expr)))
 	  {
 	    savew = warningcount, savee = errorcount;
 	    expr = build_new_method_call
diff --git a/gcc/testsuite/g++.old-deja/g++.law/cvt7.C b/gcc/testsuite/g++.old-deja/g++.law/cvt7.C
index 7529bc24bbc..0ea1d55fd43 100644
--- a/gcc/testsuite/g++.old-deja/g++.law/cvt7.C
+++ b/gcc/testsuite/g++.old-deja/g++.law/cvt7.C
@@ -10,8 +10,8 @@
 class A
 {
 public:
-    A(int j) { i = j; }		// ERROR - candidate
-    A(A& a) { i = a.i; }	// ERROR - candidate
+    A(int j) { i = j; }
+    A(A& a) { i = a.i; }
     operator int() { return i; }
 
     void assign(int v) { i = v; }
@@ -37,10 +37,10 @@ B::run()
     // Replacing above with "switch (int(in))" removes the error.
     {
     case 0:
-        out = 1;		// ERROR - no usable copy ctor
+        out = 1;
         break;
     default:
-        out = 0;		// ERROR - no usable copy ctor
+        out = 0;
         break;
     }
 }
diff --git a/gcc/testsuite/g++.old-deja/g++.mike/p5469.C b/gcc/testsuite/g++.old-deja/g++.mike/p5469.C
index 9e5250e43de..9af20101171 100644
--- a/gcc/testsuite/g++.old-deja/g++.mike/p5469.C
+++ b/gcc/testsuite/g++.old-deja/g++.mike/p5469.C
@@ -4,7 +4,7 @@ int count;
 
 class A {
   A();
-  A(const A&);			// ERROR - referenced below
+  A(const A&);
 public:
   A(int) { ++count; }
   ~A() { --count; }
@@ -14,7 +14,7 @@ public:
 int main() {
   {
     A a (1);
-    if (a == 2 && a == 1)	// ERROR - private copy ctor
+    if (a == 2 && a == 1)
       ;
   }
   return count;
diff --git a/gcc/testsuite/g++.old-deja/g++.other/copy3.C b/gcc/testsuite/g++.old-deja/g++.other/copy3.C
new file mode 100644
index 00000000000..aa2c9058f8f
--- /dev/null
+++ b/gcc/testsuite/g++.old-deja/g++.other/copy3.C
@@ -0,0 +1,23 @@
+// Build don't run:
+// Origin: ericp@mit.edu
+
+class bar {
+};
+
+class foo {  
+  foo (const foo &f);
+
+public:
+  
+  foo (bar x) {}
+  foo () {}
+  
+  void test (const foo &f) {}
+};
+
+int main (void) {
+  foo f;
+  bar b;
+
+  f.test (b);
+}