From: H.J. Lu <hjl.tools@gmail.com>
Date: Fri, 22 Sep 2017 14:25:16 +0000 (-0700)
Subject: x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b69e9267d15a09ce3f3d4599eae2952dfc6df502;p=binutils-gdb.git

x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0

Stop if bfd_canonicalize_dynamic_reloc returns 0.

	PR ld/22163
	* elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Also return
	-1 if bfd_canonicalize_dynamic_reloc returns 0.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 46643eb31da..1df9691c9e8 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2017-09-22  H.J. Lu  <hongjiu.lu@intel.com>
+
+	PR ld/22163
+	* elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Also return
+	-1 if bfd_canonicalize_dynamic_reloc returns 0.
+
 2017-09-22  Pedro Alves  <palves@redhat.com>
 	    Alan Modra  <amodra@gmail.com>
 
diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c
index 2145308ce33..11883ded36c 100644
--- a/bfd/elfxx-x86.c
+++ b/bfd/elfxx-x86.c
@@ -1807,7 +1807,7 @@ _bfd_x86_elf_get_synthetic_symtab (bfd *abfd,
 
   dynrelcount = bfd_canonicalize_dynamic_reloc (abfd, dynrelbuf,
 						dynsyms);
-  if (dynrelcount < 0)
+  if (dynrelcount <= 0)
     return -1;
 
   /* Sort the relocs by address.  */