From: Brian <brian.paul@tungstengraphics.com>
Date: Fri, 21 Mar 2008 16:03:23 +0000 (-0600)
Subject: i915: added to-do note about setting the max_lod register to get proper min/mag filte... 
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b70a6babfbc035d64dbe35ac4bf9218e8232b435;p=mesa.git

i915: added to-do note about setting the max_lod register to get proper min/mag filter selection
---

diff --git a/src/gallium/drivers/i915simple/i915_state_sampler.c b/src/gallium/drivers/i915simple/i915_state_sampler.c
index 9dbb1b1b238..84f6529a3ad 100644
--- a/src/gallium/drivers/i915simple/i915_state_sampler.c
+++ b/src/gallium/drivers/i915simple/i915_state_sampler.c
@@ -206,6 +206,12 @@ i915_update_texture(struct i915_context *i915, uint unit,
        | format
        | MS3_USE_FENCE_REGS);
 
+   /*
+    * XXX sampler->max_lod should be used to program the MAX_LOD field below.
+    * Also, when min_filter != mag_filter and there's just one mipmap level,
+    * set max_lod = 1 to make sure i915 chooses between min/mag filtering.
+    */
+
    /* MS4 state */
    state[1] =
       ((((pitch / 4) - 1) << MS4_PITCH_SHIFT)