From: J.W. Jagersma <jwjagersma@gmail.com>
Date: Wed, 25 Mar 2020 11:52:07 +0000 (+0000)
Subject: The "b" flag for COFF sections only unsets the LOAD attribute.  It should also clear... 
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b77809577782d8798bc86dde3a2a28c30d7805f0;p=binutils-gdb.git

The "b" flag for COFF sections only unsets the LOAD attribute.  It should also clear the CONTENTS attribute so that named bss sections don't take up space in an object file.  This can be achieved by setting the 'bss' flag in seg_info.

	* config/obj-coff.c (obj_coff_section): Set the bss flag on
	sections with the "b" attribute.
---

diff --git a/gas/ChangeLog b/gas/ChangeLog
index dcac44c638e..fc436ff3c3a 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-25  J.W. Jagersma  <jwjagersma@gmail.com>
+
+	* config/obj-coff.c (obj_coff_section): Set the bss flag on
+	sections with the "b" attribute.
+
 2020-03-22  Alan Modra  <amodra@gmail.com>
 
 	* testsuite/gas/s12z/truncated.d: Update expected output.
diff --git a/gas/config/obj-coff.c b/gas/config/obj-coff.c
index 178ccaad6a6..70d9fb32d50 100644
--- a/gas/config/obj-coff.c
+++ b/gas/config/obj-coff.c
@@ -1532,6 +1532,7 @@ obj_coff_section (int ignore ATTRIBUTE_UNUSED)
   unsigned int exp;
   flagword flags, oldflags;
   asection *sec;
+  bfd_boolean is_bss = FALSE;
 
   if (flag_mri)
     {
@@ -1581,6 +1582,7 @@ obj_coff_section (int ignore ATTRIBUTE_UNUSED)
 		  /* Uninitialised data section.  */
 		  flags |= SEC_ALLOC;
 		  flags &=~ SEC_LOAD;
+		  is_bss = TRUE;
 		  break;
 
 		case 'n':
@@ -1652,6 +1654,9 @@ obj_coff_section (int ignore ATTRIBUTE_UNUSED)
 
   sec = subseg_new (name, (subsegT) exp);
 
+  if (is_bss)
+    seg_info (sec)->bss = 1;
+
   if (alignment >= 0)
     sec->alignment_power = alignment;