From: Florent Kermarrec <florent@enjoy-digital.fr>
Date: Wed, 28 Aug 2019 03:15:45 +0000 (+0200)
Subject: gen/fhdl/verilog: allow single element verilog inline attribute
X-Git-Tag: 24jan2021_ls180~1033
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b845755995a8517d8e0ffa86156fb5577201f7d4;p=litex.git

gen/fhdl/verilog: allow single element verilog inline attribute
---

diff --git a/litex/build/lattice/diamond.py b/litex/build/lattice/diamond.py
index da1c441f..a22288fd 100644
--- a/litex/build/lattice/diamond.py
+++ b/litex/build/lattice/diamond.py
@@ -10,8 +10,6 @@ import shutil
 
 from migen.fhdl.structure import _Fragment
 
-from litex.gen.fhdl.verilog import DummyAttrTranslate
-
 from litex.build.generic_platform import *
 from litex.build import tools
 from litex.build.lattice import common
diff --git a/litex/gen/fhdl/verilog.py b/litex/gen/fhdl/verilog.py
index 0e34af26..b0fc69fa 100644
--- a/litex/gen/fhdl/verilog.py
+++ b/litex/gen/fhdl/verilog.py
@@ -198,11 +198,13 @@ def _printattr(attr, attr_translate):
     firsta = True
     for attr in sorted(attr,
                        key=lambda x: ("", x) if isinstance(x, str) else x):
+        # platform-dependent attribute
         if isinstance(attr, tuple):
-            # platform-dependent attribute
             attr_name, attr_value = attr
+        elif attr not in attr_translate.keys():
+            attr_name, attr_value = attr, None
+        # translated attribute
         else:
-            # translated attribute
             at = attr_translate[attr]
             if at is None:
                 continue
@@ -210,7 +212,9 @@ def _printattr(attr, attr_translate):
         if not firsta:
             r += ", "
         firsta = False
-        r += attr_name + " = \"" + attr_value + "\""
+        r += attr_name
+        if attr_value is not None:
+            r += " = \"" + attr_value + "\""
     if r:
         r = "(* " + r + " *)"
     return r
@@ -366,14 +370,9 @@ def _printspecials(overrides, specials, ns, add_data_file, attr_translate):
     return r
 
 
-class DummyAttrTranslate:
-    def __getitem__(self, k):
-        return (k, "true")
-
-
 def convert(f, ios=None, name="top",
   special_overrides=dict(),
-  attr_translate=DummyAttrTranslate(),
+  attr_translate={},
   create_clock_domains=True,
   display_run=False,
   reg_initialization=True,