From: Keith Whitwell <keithw@vmware.com>
Date: Fri, 6 Nov 2009 08:28:17 +0000 (+0000)
Subject: i965g: point_rast_rule comment no longer applies
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b8e63e92102b6ca0b5ce06685590232a3a47d1ea;p=mesa.git

i965g: point_rast_rule comment no longer applies

Not sure exactly what state we want here now, will need to experiment.
---

diff --git a/src/gallium/drivers/i965/brw_sf_state.c b/src/gallium/drivers/i965/brw_sf_state.c
index 955478e6240..25dc2b52e07 100644
--- a/src/gallium/drivers/i965/brw_sf_state.c
+++ b/src/gallium/drivers/i965/brw_sf_state.c
@@ -221,32 +221,10 @@ sf_unit_create_from_key(struct brw_context *brw,
 
    /* XXX: gl_rasterization_rules?  something else?
     */
-   if (0) {
-      /* Rendering to an OpenGL window */
-      sf.sf6.point_rast_rule = BRW_RASTRULE_UPPER_RIGHT;
-   }
-   else {
-      /* If rendering to an FBO, the pixel coordinate system is
-       * inverted with respect to the normal OpenGL coordinate
-       * system, so BRW_RASTRULE_LOWER_RIGHT is correct.
-       * But this value is listed as "Reserved, but not seen as useful"
-       * in Intel documentation (page 212, "Point Rasterization Rule",
-       * section 7.4 "SF Pipeline State Summary", of document
-       * "Intel® 965 Express Chipset Family and Intel® G35 Express
-       * Chipset Graphics Controller Programmer's Reference Manual,
-       * Volume 2: 3D/Media", Revision 1.0b as of January 2008,
-       * available at 
-       *     http://intellinuxgraphics.org/documentation.html
-       * at the time of this writing).
-       *
-       * It does work on at least some devices, if not all;
-       * if devices that don't support it can be identified,
-       * the likely failure case is that points are rasterized
-       * incorrectly, which is no worse than occurs without
-       * the value, so we're using it here.
-       */
-      sf.sf6.point_rast_rule = BRW_RASTRULE_LOWER_RIGHT;
-   }
+   sf.sf6.point_rast_rule = BRW_RASTRULE_UPPER_RIGHT;
+   sf.sf6.point_rast_rule = BRW_RASTRULE_LOWER_RIGHT;
+   sf.sf6.point_rast_rule = 1;
+
    /* XXX clamp max depends on AA vs. non-AA */
 
    /* _NEW_POINT */