From: Mark Kettenis <kettenis@gnu.org>
Date: Wed, 28 Mar 2001 08:35:14 +0000 (+0000)
Subject: * i386-linux-nat.c (i386_linux_dr_get): Return 0 if ptrace call
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b9511b9a9a06835ac22efe5e37f54aec65f3219e;p=binutils-gdb.git

* i386-linux-nat.c (i386_linux_dr_get): Return 0 if ptrace call
fails instead of calling perror_with_name.  This should fix
debugging remote i386 targets with a native Linux/x86 GDB.  Add
FIXME for this hack.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f23e5e35cb8..e0e89effa5f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2001-03-28  Mark Kettenis  <kettenis@gnu.org>
+
+	* i386-linux-nat.c (i386_linux_dr_get): Return 0 if ptrace call
+	fails instead of calling perror_with_name.  This should fix
+	debugging remote i386 targets with a native Linux/x86 GDB.  Add
+	FIXME for this hack.
+
 2001-03-19  J.T. Conklin  <jtc@redback.com>
 
 	* arch-utils.c (#include "gdbthread.h"): Removed.
diff --git a/gdb/i386-linux-nat.c b/gdb/i386-linux-nat.c
index aac92896343..66b0159e723 100644
--- a/gdb/i386-linux-nat.c
+++ b/gdb/i386-linux-nat.c
@@ -712,11 +712,20 @@ i386_linux_dr_get (int regnum)
      one thread.  */
   tid = PIDGET (inferior_pid);
 
+  /* FIXME: kettenis/2001-03-27: Calling perror_with_name if the
+     ptrace call fails breaks debugging remote targets.  The correct
+     way to fix this is to add the hardware breakpoint and watchpoint
+     stuff to the target vectore.  For now, just return zero if the
+     ptrace call fails.  */
   errno = 0;
   value = ptrace (PT_READ_U, tid,
 		  offsetof (struct user, u_debugreg[regnum]), 0);
   if (errno != 0)
+#if 0
     perror_with_name ("Couldn't read debug register");
+#else
+    return 0;
+#endif
 
   return value;
 }