From: Eric Anholt <eric@anholt.net>
Date: Wed, 31 Mar 2010 18:20:58 +0000 (-1000)
Subject: Test that variable names don't use the reserved gl_ prefix.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=b97ee2e260efb68849ee13402072b7d7185746d5;p=mesa.git

Test that variable names don't use the reserved gl_ prefix.

Fixes identifier2.frag.
---

diff --git a/ast_to_hir.cpp b/ast_to_hir.cpp
index f66c0298085..708656a6fce 100644
--- a/ast_to_hir.cpp
+++ b/ast_to_hir.cpp
@@ -1177,6 +1177,21 @@ ast_declarator_list::hir(exec_list *instructions,
 	 continue;
       }
 
+      /* From page 15 (page 21 of the PDF) of the GLSL 1.10 spec,
+       *
+       *   "Identifiers starting with "gl_" are reserved for use by
+       *   OpenGL, and may not be declared in a shader as either a
+       *   variable or a function."
+       */
+      if (strncmp(decl->identifier, "gl_", 3) == 0) {
+	 /* FINISHME: This should only trigger if we're not redefining
+	  * FINISHME: a builtin (to add a qualifier, for example).
+	  */
+	 _mesa_glsl_error(& loc, state,
+			  "identifier `%s' uses reserved `gl_' prefix",
+			  decl->identifier);
+      }
+
       instructions->push_tail(var);
 
       if (this->type->qualifier.attribute