From: Daniel R. Carvalho <odanrc@yahoo.com.br>
Date: Fri, 25 Dec 2020 20:43:11 +0000 (-0300)
Subject: base: Fix uninitialized variable in Flag
X-Git-Tag: develop-gem5-snapshot~306
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ba284a13ddc381bf8d13d736256820c74b961821;p=gem5.git

base: Fix uninitialized variable in Flag

This was uninitialized, and was breaking expected values
under certain situations.

Change-Id: If51ab6ae038c7c397bc83de1c73af348c1db4ef8
Signed-off-by: Daniel R. Carvalho <odanrc@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38707
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>
---

diff --git a/src/base/debug.cc b/src/base/debug.cc
index 45d9f9d59..9cfd45ec4 100644
--- a/src/base/debug.cc
+++ b/src/base/debug.cc
@@ -100,6 +100,8 @@ Flag::Flag(const char *name, const char *desc)
         panic("Flag %s already defined!", name);
 
     ++allFlagsVersion;
+
+    sync();
 }
 
 Flag::~Flag()
diff --git a/src/base/debug.hh b/src/base/debug.hh
index 7cc71375b..6006b14b9 100644
--- a/src/base/debug.hh
+++ b/src/base/debug.hh
@@ -82,15 +82,13 @@ class Flag
 class SimpleFlag : public Flag
 {
   protected:
-    bool _tracing; // tracing is enabled and flag is on
-    bool _status;  // flag status
+    bool _tracing = false; // tracing is enabled and flag is on
+    bool _status = false;  // flag status
 
     void sync() override { _tracing = _globalEnable && _status; }
 
   public:
-    SimpleFlag(const char *name, const char *desc)
-        : Flag(name, desc), _status(false)
-    { }
+    SimpleFlag(const char *name, const char *desc) : Flag(name, desc) {}
 
     bool status() const override { return _tracing; }