From: Jan Hubicka <hubicka@ucw.cz>
Date: Tue, 12 Feb 2019 11:25:11 +0000 (+0100)
Subject: re PR target/88777 (Out-of-range offsets building glibc test-tgmath2.c for hppa-linux... 
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=baaf860b3364f2efac1cb04a1430f82f867768ef;p=gcc.git

re PR target/88777 (Out-of-range offsets building glibc test-tgmath2.c for hppa-linux-gnu)


	PR lto/88777
	* cgraphunit.c (analyze_functions): Clear READONLY flag for external
	types that needs constructiong.
	* tree.h (may_be_aliased): Do not check TYPE_NEEDS_CONSTRUCTING.

From-SVN: r268791
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index fd015eb2be6..c430e9d5ecd 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2019-02-12  Jan Hubicka  <hubicka@ucw.cz>
+
+	PR lto/88777
+	* cgraphunit.c (analyze_functions): Clear READONLY flag for external
+	types that needs constructiong.
+	* tree.h (may_be_aliased): Do not check TYPE_NEEDS_CONSTRUCTING.
+
 2019-02-12  Richard Biener  <rguenther@suse.de>
 
 	PR tree-optimization/89253
diff --git a/gcc/cgraphunit.c b/gcc/cgraphunit.c
index a7c9b9ac249..162e0049b6b 100644
--- a/gcc/cgraphunit.c
+++ b/gcc/cgraphunit.c
@@ -1226,6 +1226,15 @@ analyze_functions (bool first_time)
        && node != first_handled_var; node = next)
     {
       next = node->next;
+      /* For symbols declared locally we clear TREE_READONLY when emitting
+	 the construtor (if one is needed).  For external declarations we can
+	 not safely assume that the type is readonly because we may be called
+	 during its construction.  */
+      if (TREE_CODE (node->decl) == VAR_DECL
+	  && TYPE_P (TREE_TYPE (node->decl))
+	  && TYPE_NEEDS_CONSTRUCTING (TREE_TYPE (node->decl))
+	  && DECL_EXTERNAL (node->decl))
+	TREE_READONLY (node->decl) = 0;
       if (!node->aux && !node->referred_to_p ())
 	{
 	  if (symtab->dump_file)
diff --git a/gcc/tree.h b/gcc/tree.h
index a1c30e42cce..96d84d961c5 100644
--- a/gcc/tree.h
+++ b/gcc/tree.h
@@ -5382,8 +5382,7 @@ may_be_aliased (const_tree var)
 	      || DECL_EXTERNAL (var)
 	      || TREE_ADDRESSABLE (var))
 	  && !((TREE_STATIC (var) || TREE_PUBLIC (var) || DECL_EXTERNAL (var))
-	       && ((TREE_READONLY (var)
-		    && !TYPE_NEEDS_CONSTRUCTING (TREE_TYPE (var)))
+	       && (TREE_READONLY (var)
 		   || (TREE_CODE (var) == VAR_DECL
 		       && DECL_NONALIASED (var)))));
 }