From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Mon, 8 Apr 2019 04:07:02 +0000 (+0100)
Subject: split out allocate and specallocate from StageChain setup, simpler to read
X-Git-Tag: ls180-24jan2020~1290
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=bac24a3483ebaf03f12d74a25872891b740aec96;p=ieee754fpu.git

split out allocate and specallocate from StageChain setup, simpler to read
---

diff --git a/src/add/singlepipe.py b/src/add/singlepipe.py
index abf672c3..af6b711b 100644
--- a/src/add/singlepipe.py
+++ b/src/add/singlepipe.py
@@ -403,23 +403,31 @@ class StageChain(StageCls):
     def ospec(self):
         return self.chain[-1].ospec()
 
-    def setup(self, m, i):
+    def _specallocate_setup(self, m, i):
         for (idx, c) in enumerate(self.chain):
             if hasattr(c, "setup"):
                 c.setup(m, i)               # stage may have some module stuff
-            if self.specallocate:
-                o = self.chain[idx].ospec()     # last assignment survives
-                m.d.comb += eq(o, c.process(i)) # process input into "o"
-            else:
-                o = c.process(i) # store input into "o"
-            if idx != len(self.chain)-1:
-                if self.specallocate:
-                    ni = self.chain[idx+1].ispec() # new input on next loop
-                    m.d.comb += eq(ni, o)          # assign to next input
-                    i = ni
-                else:
-                    i = o
-        self.o = o                             # last loop is the output
+            o = self.chain[idx].ospec()     # last assignment survives
+            m.d.comb += eq(o, c.process(i)) # process input into "o"
+            if idx == len(self.chain)-1:
+                continue
+            ni = self.chain[idx+1].ispec()  # new input on next loop
+            m.d.comb += eq(ni, o)           # assign to next input
+            i = ni
+        return o                            # last loop is the output
+
+    def _noallocate_setup(self, m, i):
+        for (idx, c) in enumerate(self.chain):
+            if hasattr(c, "setup"):
+                c.setup(m, i)               # stage may have some module stuff
+            i = o = c.process(i)            # store input into "o"
+        return o                            # last loop is the output
+
+    def setup(self, m, i):
+        if self.specallocate:
+            self.o = self._specallocate_setup(m, i)
+        else:
+            self.o = self._noallocate_setup(m, i)
 
     def process(self, i):
         return self.o # conform to Stage API: return last-loop output