From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Thu, 2 Nov 2023 07:14:58 +0000 (+0000)
Subject: comment on rfid doing a swap-backup of the program, must find
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=bb89ceb45e1227fe41d42d4ff44f42c31c41c788;p=openpower-isa.git

comment on rfid doing a swap-backup of the program, must find
out why and fix it so that is not necessary
---

diff --git a/src/openpower/decoder/isa/caller.py b/src/openpower/decoder/isa/caller.py
index ba6252c2..73d8bc40 100644
--- a/src/openpower/decoder/isa/caller.py
+++ b/src/openpower/decoder/isa/caller.py
@@ -1996,6 +1996,8 @@ class ISACaller(ISACallerHelper, ISAFPHelpers, StepLoop):
         # 2. Call the HDL implementation which invokes trap.
         # 3. Reroute the guest system call to host system call.
         # 4. Force return from the interrupt as if we had guest OS.
+        #    "executing" rfid requires putting 0x4c000024 temporarily
+        #    into the program at the PC. TODO investigate and remove
         if ((asmop in ("sc", "scv")) and
                 (self.syscall is not None) and
                 not syscall_emu_active):