From: Andrey Smirnov Date: Tue, 7 Nov 2017 20:04:42 +0000 (-0800) Subject: package/collectd: Specify FP layout based on endianness X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=bdd8475b90fa46644149d34bf852b213ec60ce71;p=buildroot.git package/collectd: Specify FP layout based on endianness Big-endian CPUs store floating point as big endian (at lest majority of them do), so, in order for 'network' plugin to work correctly (and potentially any user of htond() in collectd's codebase), --with-fp-layout=endianflip as opposed to --with-fp-layout=nothing needs to be specified during configuration phase. Cc: Thomas Petazzoni Cc: Arnout Vandecappelle Cc: Gustavo Zacarias Signed-off-by: Andrey Smirnov Reviewed-by: Thomas Petazzoni Signed-off-by: Thomas Petazzoni --- diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk index 626fba81bf..6c987b2e36 100644 --- a/package/collectd/collectd.mk +++ b/package/collectd/collectd.mk @@ -24,9 +24,23 @@ COLLECTD_PLUGINS_DISABLE = \ COLLECTD_CONF_ENV += LIBS="-lm" +# +# NOTE: There's also a third availible setting "intswap", which might +# be needed on some old ARM hardware (see [2]), but is not being +# accounted for as per discussion [1] +# +# [1] http://lists.busybox.net/pipermail/buildroot/2017-November/206100.html +# [2] http://lists.busybox.net/pipermail/buildroot/2017-November/206251.html +# +ifeq ($(BR2_ENDIAN),"BIG") +COLLECTD_FP_LAYOUT=endianflip +else +COLLECTD_FP_LAYOUT=nothing +endif + COLLECTD_CONF_OPTS += \ --with-nan-emulation \ - --with-fp-layout=nothing \ + --with-fp-layout=$(COLLECTD_FP_LAYOUT) \ --with-perl-bindings=no \ $(foreach p, $(COLLECTD_PLUGINS_DISABLE), --disable-$(p)) \ $(if $(BR2_PACKAGE_COLLECTD_AGGREGATION),--enable-aggregation,--disable-aggregation) \