From: Mark Mitchell Date: Fri, 20 Jul 2001 02:38:57 +0000 (+0000) Subject: reorg.c (fill_simple_delay_slots): If an instruction might throw an exception that... X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=be672de8aefdbad33db28b2fa397bafde5c39e0c;p=gcc.git reorg.c (fill_simple_delay_slots): If an instruction might throw an exception that will be caught within this... * reorg.c (fill_simple_delay_slots): If an instruction might throw an exception that will be caught within this function, do not fill its delay slot with any subsequent instruction. From-SVN: r44171 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 5850d786690..693d0620d29 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2001-07-19 Mark Mitchell + + * reorg.c (fill_simple_delay_slots): If an instruction might throw + an exception that will be caught within this function, do not fill + its delay slot with any subsequent instruction. + 2001-07-19 Steve Ellcey * tm.texi (POINTERS_EXTEND_UNSIGNED) Modify definition. diff --git a/gcc/reorg.c b/gcc/reorg.c index b521645d621..1f26e7e3751 100644 --- a/gcc/reorg.c +++ b/gcc/reorg.c @@ -2223,6 +2223,27 @@ fill_simple_delay_slots (non_jumps_p) fill_eager_delay_slots anyways, it was just deleted. */ if (slots_filled != slots_to_fill + /* If this instruction could throw an exception which is + caught in the same function, then it's not safe to fill + the delay slot with an instruction from beyond this + point. For example, consider: + + int i = 2; + + try { + f(); + i = 3; + } catch (...) {} + + return i; + + Even though `i' is a local variable, we must be sure not + to put `i = 3' in the delay slot if `f' might throw an + exception. + + Presumably, we should also check to see if we could get + back to this function via `setjmp'. */ + && !can_throw_internal (insn) && (GET_CODE (insn) != JUMP_INSN || ((condjump_p (insn) || condjump_in_parallel_p (insn)) && ! simplejump_p (insn)