From: Mike Frysinger Date: Sat, 9 Jan 2021 06:16:11 +0000 (-0500) Subject: sim: enable -Werror by default for some arches X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=bf470982f998b2b18545cc335f469a20e457acdd;p=binutils-gdb.git sim: enable -Werror by default for some arches We've had this off for a long time because the sim code was way too full of warnings for it to be feasible. However, I've cleaned things up significantly from when this was first merged, and we can start to turn this around. Change the macro to enable -Werror by default, and allow ports to opt out. New ports will get it automatically (and we can push back on them if they try to turn it off). Also turn it off for the few ports that still hit warnings for me. All the rest will get the new default, and we'll wait for feedback if/when new issues come up. --- diff --git a/sim/aarch64/ChangeLog b/sim/aarch64/ChangeLog index 97e33401afc..5708802be00 100644 --- a/sim/aarch64/ChangeLog +++ b/sim/aarch64/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/aarch64/configure b/sim/aarch64/configure index a5ed5c95da9..6df9f8d7f3e 100755 --- a/sim/aarch64/configure +++ b/sim/aarch64/configure @@ -13688,11 +13688,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/arm/ChangeLog b/sim/arm/ChangeLog index 560632a0a87..67060927b06 100644 --- a/sim/arm/ChangeLog +++ b/sim/arm/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/arm/configure b/sim/arm/configure index 692cd9004d7..34002b2e047 100755 --- a/sim/arm/configure +++ b/sim/arm/configure @@ -13684,11 +13684,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/avr/ChangeLog b/sim/avr/ChangeLog index 810bd5864ad..c368fa4681b 100644 --- a/sim/avr/ChangeLog +++ b/sim/avr/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/avr/configure b/sim/avr/configure index 7cc3478c42d..5246f8efbfd 100755 --- a/sim/avr/configure +++ b/sim/avr/configure @@ -13684,11 +13684,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/bfin/ChangeLog b/sim/bfin/ChangeLog index 12127ecbf7c..1ac810e8a1e 100644 --- a/sim/bfin/ChangeLog +++ b/sim/bfin/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/bfin/configure b/sim/bfin/configure index 0492d3893c1..4131fb57e80 100755 --- a/sim/bfin/configure +++ b/sim/bfin/configure @@ -13743,11 +13743,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog index 28284ff8444..fea1ab2ff03 100644 --- a/sim/common/ChangeLog +++ b/sim/common/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * acinclude.m4 (SIM_AC_OPTION_WARNINGS): Document 1st argument. + Set WERROR_CFLAGS when first arg is not set or is "yes". + 2021-01-09 Mike Frysinger * hw-base.c (full_name_of_hw): Delete full_name. Replace diff --git a/sim/common/acinclude.m4 b/sim/common/acinclude.m4 index 49d56b97f9b..65afb429d6e 100644 --- a/sim/common/acinclude.m4 +++ b/sim/common/acinclude.m4 @@ -737,6 +737,7 @@ AC_MSG_RESULT($sim_smp) dnl --enable-build-warnings is for developers of the simulator. dnl it enables extra GCC specific warnings. +dnl arg[1] Enable -Werror by default? ("yes" or "no") AC_DEFUN([SIM_AC_OPTION_WARNINGS], [ AC_ARG_ENABLE(werror, @@ -753,11 +754,11 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi +m4_if(m4_default([$1], [yes]), [yes], [dnl + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi +])dnl build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/cr16/ChangeLog b/sim/cr16/ChangeLog index 1de8e15b55e..2b58f8845e6 100644 --- a/sim/cr16/ChangeLog +++ b/sim/cr16/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/cr16/configure b/sim/cr16/configure index ff93efd92db..bfde3169e34 100755 --- a/sim/cr16/configure +++ b/sim/cr16/configure @@ -13684,11 +13684,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/cr16/configure.ac b/sim/cr16/configure.ac index 4f416b9247a..3155e4bd14f 100644 --- a/sim/cr16/configure.ac +++ b/sim/cr16/configure.ac @@ -6,6 +6,6 @@ SIM_AC_COMMON SIM_AC_OPTION_ENDIAN(LITTLE) SIM_AC_OPTION_ALIGNMENT(NONSTRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OUTPUT diff --git a/sim/cris/ChangeLog b/sim/cris/ChangeLog index 1c4bda1f0c2..0a057d9fcb3 100644 --- a/sim/cris/ChangeLog +++ b/sim/cris/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/cris/configure b/sim/cris/configure index 96f545df4b0..e75a8ced0cb 100755 --- a/sim/cris/configure +++ b/sim/cris/configure @@ -13732,11 +13732,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/cris/configure.ac b/sim/cris/configure.ac index 2ac3266577a..12e0023e864 100644 --- a/sim/cris/configure.ac +++ b/sim/cris/configure.ac @@ -10,7 +10,7 @@ AC_CHECK_HEADERS(sys/socket.h sys/select.h limits.h sys/param.h) SIM_AC_OPTION_ENDIAN(LITTLE) SIM_AC_OPTION_ALIGNMENT(NONSTRICT_ALIGNMENT) SIM_AC_OPTION_SCACHE(16384) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OPTION_HARDWARE(yes,,rv cris cris_900000xx) # The default model shouldn't matter as long as there's a BFD. diff --git a/sim/d10v/ChangeLog b/sim/d10v/ChangeLog index a53becd6558..cad30638e98 100644 --- a/sim/d10v/ChangeLog +++ b/sim/d10v/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/d10v/configure b/sim/d10v/configure index 692cd9004d7..f0ce157bee7 100755 --- a/sim/d10v/configure +++ b/sim/d10v/configure @@ -13684,11 +13684,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/d10v/configure.ac b/sim/d10v/configure.ac index 5dffa14bccc..1551df5a4a6 100644 --- a/sim/d10v/configure.ac +++ b/sim/d10v/configure.ac @@ -6,6 +6,6 @@ SIM_AC_COMMON SIM_AC_OPTION_ENDIAN SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT,STRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OUTPUT diff --git a/sim/ft32/ChangeLog b/sim/ft32/ChangeLog index 48235fb6916..ad31e24e01f 100644 --- a/sim/ft32/ChangeLog +++ b/sim/ft32/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/ft32/configure b/sim/ft32/configure index 94c3a43b302..4defb86a7bb 100755 --- a/sim/ft32/configure +++ b/sim/ft32/configure @@ -13684,11 +13684,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/igen/ChangeLog b/sim/igen/ChangeLog index bf2ee3e912e..7f9e87aa917 100644 --- a/sim/igen/ChangeLog +++ b/sim/igen/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-04 Mike Frysinger * gen-icache.c, igen.c: Include stdlib.h. diff --git a/sim/igen/configure b/sim/igen/configure index 9ed39bfa128..0239c526163 100755 --- a/sim/igen/configure +++ b/sim/igen/configure @@ -4810,11 +4810,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/m32c/ChangeLog b/sim/m32c/ChangeLog index 1179044b5f4..ccaae943eef 100644 --- a/sim/m32c/ChangeLog +++ b/sim/m32c/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/m32c/configure b/sim/m32c/configure index 29df076e598..18cd590a913 100755 --- a/sim/m32c/configure +++ b/sim/m32c/configure @@ -13586,11 +13586,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/m32c/configure.ac b/sim/m32c/configure.ac index 435741904ad..9477c23b7a1 100644 --- a/sim/m32c/configure.ac +++ b/sim/m32c/configure.ac @@ -23,7 +23,7 @@ sinclude(../common/acinclude.m4) SIM_AC_COMMON -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) AC_CHECK_HEADERS(sys/select.h termios.h sys/socket.h netinet/in.h netinet/tcp.h) diff --git a/sim/m68hc11/ChangeLog b/sim/m68hc11/ChangeLog index 5f57a70710a..c10bf1f49ac 100644 --- a/sim/m68hc11/ChangeLog +++ b/sim/m68hc11/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/m68hc11/configure b/sim/m68hc11/configure index 2d8ff6b8e4b..44a1daa1323 100755 --- a/sim/m68hc11/configure +++ b/sim/m68hc11/configure @@ -13687,11 +13687,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/m68hc11/configure.ac b/sim/m68hc11/configure.ac index 34760decd86..800da69c8e4 100644 --- a/sim/m68hc11/configure.ac +++ b/sim/m68hc11/configure.ac @@ -7,7 +7,7 @@ SIM_AC_COMMON dnl Options available in this module SIM_AC_OPTION_ENDIAN(BIG) SIM_AC_OPTION_ALIGNMENT(NONSTRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) # # Add simulated hardware devices diff --git a/sim/mcore/ChangeLog b/sim/mcore/ChangeLog index b0b065455f7..3fa83bd9f77 100644 --- a/sim/mcore/ChangeLog +++ b/sim/mcore/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/mcore/configure b/sim/mcore/configure index 692cd9004d7..f0ce157bee7 100755 --- a/sim/mcore/configure +++ b/sim/mcore/configure @@ -13684,11 +13684,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/mcore/configure.ac b/sim/mcore/configure.ac index 5dffa14bccc..1551df5a4a6 100644 --- a/sim/mcore/configure.ac +++ b/sim/mcore/configure.ac @@ -6,6 +6,6 @@ SIM_AC_COMMON SIM_AC_OPTION_ENDIAN SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT,STRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OUTPUT diff --git a/sim/microblaze/ChangeLog b/sim/microblaze/ChangeLog index 793e46c313b..523971ca99c 100644 --- a/sim/microblaze/ChangeLog +++ b/sim/microblaze/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/microblaze/configure b/sim/microblaze/configure index 692cd9004d7..34002b2e047 100755 --- a/sim/microblaze/configure +++ b/sim/microblaze/configure @@ -13684,11 +13684,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/mips/ChangeLog b/sim/mips/ChangeLog index 17d5ab7d91a..f69a59d970e 100644 --- a/sim/mips/ChangeLog +++ b/sim/mips/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/mips/configure b/sim/mips/configure index 7180ced00e1..b226e38e28b 100755 --- a/sim/mips/configure +++ b/sim/mips/configure @@ -13672,11 +13672,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/mips/configure.ac b/sim/mips/configure.ac index 63670f269a0..ad99e648e09 100644 --- a/sim/mips/configure.ac +++ b/sim/mips/configure.ac @@ -6,7 +6,7 @@ SIM_AC_COMMON dnl Options available in this module SIM_AC_OPTION_ALIGNMENT(NONSTRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OPTION_RESERVED_BITS(1) # DEPRECATED diff --git a/sim/mn10300/ChangeLog b/sim/mn10300/ChangeLog index 8f3c1111795..c35be9edab0 100644 --- a/sim/mn10300/ChangeLog +++ b/sim/mn10300/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/mn10300/configure b/sim/mn10300/configure index b8d356604ba..52d8a126123 100755 --- a/sim/mn10300/configure +++ b/sim/mn10300/configure @@ -13693,11 +13693,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/mn10300/configure.ac b/sim/mn10300/configure.ac index 33ca50f055b..d888d3c1492 100644 --- a/sim/mn10300/configure.ac +++ b/sim/mn10300/configure.ac @@ -6,7 +6,7 @@ SIM_AC_COMMON SIM_AC_OPTION_ENDIAN(LITTLE) SIM_AC_OPTION_ALIGNMENT(NONSTRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OPTION_RESERVED_BITS SIM_AC_OPTION_BITSIZE(32,31) SIM_AC_OPTION_HARDWARE(yes,,mn103cpu mn103int mn103tim mn103ser mn103iop) diff --git a/sim/moxie/ChangeLog b/sim/moxie/ChangeLog index 8e1b1abe008..c084f39c14e 100644 --- a/sim/moxie/ChangeLog +++ b/sim/moxie/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/moxie/configure b/sim/moxie/configure index 598d6547c6f..7def6671247 100755 --- a/sim/moxie/configure +++ b/sim/moxie/configure @@ -13778,11 +13778,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/moxie/configure.ac b/sim/moxie/configure.ac index 3f2e55389e3..a02e13a3dcb 100644 --- a/sim/moxie/configure.ac +++ b/sim/moxie/configure.ac @@ -8,6 +8,6 @@ AC_CHECK_TOOL(DTC, dtc) SIM_AC_OPTION_ENDIAN(BIG) SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OUTPUT diff --git a/sim/msp430/ChangeLog b/sim/msp430/ChangeLog index bc5a1e8ae5b..1f1a0c457b2 100644 --- a/sim/msp430/ChangeLog +++ b/sim/msp430/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/msp430/configure b/sim/msp430/configure index e6f51281d4e..0e125ce1c9b 100755 --- a/sim/msp430/configure +++ b/sim/msp430/configure @@ -13697,11 +13697,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/pru/ChangeLog b/sim/pru/ChangeLog index 0b37812439f..b5563a8c192 100644 --- a/sim/pru/ChangeLog +++ b/sim/pru/ChangeLog @@ -1,3 +1,7 @@ +2021-01-09 Mike Frysinger + + * configure: Regenerate. + 2021-01-09 Mike Frysinger * sim-main.h: Include config.h. diff --git a/sim/pru/configure b/sim/pru/configure index 7cc3478c42d..5246f8efbfd 100755 --- a/sim/pru/configure +++ b/sim/pru/configure @@ -13684,11 +13684,9 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi + if test "${ERROR_ON_WARNING}" = yes ; then + WERROR_CFLAGS="-Werror" + fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/sh/ChangeLog b/sim/sh/ChangeLog index 124a216fd06..31643210140 100644 --- a/sim/sh/ChangeLog +++ b/sim/sh/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/sh/configure b/sim/sh/configure index 692cd9004d7..f0ce157bee7 100755 --- a/sim/sh/configure +++ b/sim/sh/configure @@ -13684,11 +13684,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/sh/configure.ac b/sim/sh/configure.ac index 5dffa14bccc..1551df5a4a6 100644 --- a/sim/sh/configure.ac +++ b/sim/sh/configure.ac @@ -6,6 +6,6 @@ SIM_AC_COMMON SIM_AC_OPTION_ENDIAN SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT,STRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OUTPUT diff --git a/sim/v850/ChangeLog b/sim/v850/ChangeLog index fe9bed958fb..e1f35d9c1ca 100644 --- a/sim/v850/ChangeLog +++ b/sim/v850/ChangeLog @@ -1,3 +1,8 @@ +2021-01-09 Mike Frysinger + + * configure.ac (SIM_AC_OPTION_WARNINGS): Pass "no". + * configure: Regenerate. + 2021-01-08 Mike Frysinger * configure: Regenerate. diff --git a/sim/v850/configure b/sim/v850/configure index 1067b56e0e8..f59902c09c8 100755 --- a/sim/v850/configure +++ b/sim/v850/configure @@ -13690,11 +13690,6 @@ if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then fi WERROR_CFLAGS="" -if test "${ERROR_ON_WARNING}" = yes ; then -# NOTE: Disabled in the sim dir due to most sims generating warnings. -# WERROR_CFLAGS="-Werror" - true -fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wpointer-sign \ diff --git a/sim/v850/configure.ac b/sim/v850/configure.ac index 73f9e536b40..31bca400dc2 100644 --- a/sim/v850/configure.ac +++ b/sim/v850/configure.ac @@ -6,7 +6,7 @@ SIM_AC_COMMON SIM_AC_OPTION_ENDIAN(LITTLE) SIM_AC_OPTION_ALIGNMENT(,NONSTRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS +SIM_AC_OPTION_WARNINGS(no) SIM_AC_OPTION_RESERVED_BITS SIM_AC_OPTION_BITSIZE(32,31)