From: Michel Dänzer <michel@tungstengraphics.com>
Date: Fri, 4 Apr 2008 08:06:13 +0000 (+0100)
Subject: gallium: Always allocate new const buffers instead of modifying existing ones.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=c07d3f6a9e62bd88e05d4ebf72430139b0531be8;p=mesa.git

gallium: Always allocate new const buffers instead of modifying existing ones.
---

diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c
index cd7372902b8..03093579e15 100644
--- a/src/mesa/state_tracker/st_atom_constbuf.c
+++ b/src/mesa/state_tracker/st_atom_constbuf.c
@@ -71,13 +71,12 @@ void st_upload_constants( struct st_context *st,
 
       _mesa_load_state_parameters(st->ctx, params);
 
-      if (cbuf->buffer && cbuf->size != paramBytes)
-	 pipe_buffer_reference( ws, &cbuf->buffer, NULL );
-
-      if (!cbuf->buffer) {
-         cbuf->buffer = ws->buffer_create(ws, 1, PIPE_BUFFER_USAGE_CONSTANT,
-                                          paramBytes);
-      }
+      /* We always need to get a new buffer, to keep the drivers simple and
+       * avoid gratuitous rendering synchronization.
+       */
+      pipe_buffer_reference( ws, &cbuf->buffer, NULL );
+      cbuf->buffer = ws->buffer_create( ws, 1, PIPE_BUFFER_USAGE_CONSTANT,
+					paramBytes );
 
       if (0)
       {