From: Eric Anholt Date: Sat, 16 Feb 2013 05:55:30 +0000 (-0800) Subject: i965/fs: Only do CSE when the dst types match. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=c2a6e529c3bc9e62ad93beb1f5ae427dbbba8a38;p=mesa.git i965/fs: Only do CSE when the dst types match. We could potentially do some CSE even when the dst types aren't the same on gen6 where there is no implicit dst type conversion iirc, or in the case of uniform pull constant loads where the dst type doesn't impact what's stored. But it's not worth worrying about. Reviewed-by: Kenneth Graunke NOTE: This is a candidate for the 9.1 branch. --- diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp index 70c143af90e..a13ca362699 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp @@ -105,7 +105,8 @@ fs_visitor::opt_cse_local(bblock_t *block, exec_list *aeb) /* Match current instruction's expression against those in AEB. */ if (inst->opcode == entry->generator->opcode && inst->saturate == entry->generator->saturate && - operands_match(entry->generator->src, inst->src)) { + inst->dst.type == entry->generator->dst.type && + operands_match(entry->generator->src, inst->src)) { found = true; progress = true;