From: Chad Versace <chadversary@chromium.org>
Date: Mon, 12 Nov 2018 22:45:47 +0000 (-0800)
Subject: turnip: Don't return from tu_stub funcs
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=c3b5eea2cc7592219d6b4e7f4aea06846266bad8;p=mesa.git

turnip: Don't return from tu_stub funcs

Since the macros are lowercase and look like normal functions, that they
change control flow with a hidden return is surprising.
---

diff --git a/src/freedreno/vulkan/tu_private.h b/src/freedreno/vulkan/tu_private.h
index 26a342f6652..d6271f3465e 100644
--- a/src/freedreno/vulkan/tu_private.h
+++ b/src/freedreno/vulkan/tu_private.h
@@ -262,16 +262,9 @@ tu_logi_v(const char *format, va_list va);
 #define tu_use_args(...) __tu_use_args(0, ##__VA_ARGS__)
 static inline void __tu_use_args(int ignore, ...) {}
 
-#define tu_stub_return(v)                                                         \
-   do {                                                                        \
-      tu_finishme("stub %s", __func__);                                       \
-      return (v);                                                              \
-   } while (0)
-
 #define tu_stub()                                                                 \
    do {                                                                        \
       tu_finishme("stub %s", __func__);                                       \
-      return;                                                                  \
    } while (0)
 
 void *