From: Carl Worth <cworth@cworth.org>
Date: Tue, 22 Jun 2010 22:51:34 +0000 (-0700)
Subject: preprocessor: Initialize a potentially uninitialized variable.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=c42e64099b80e112eb0b172801a7107e143f78dc;p=mesa.git

preprocessor: Initialize a potentially uninitialized variable.

My current reading of the relevant static functions suggests that last
is never used without being uninitialized, (we only use it if the
expansion function returned non-NULL and the expansion functions
always set it before returning non-NULL).

Apparently gcc isn't coming to the same conclusion. Initializing this
to NULL nicely quites gcc and will guarantee a nice, early segfault if
my anaylsis turns out to be wrong.
---

diff --git a/glcpp/glcpp-parse.y b/glcpp/glcpp-parse.y
index 88a30f89755..6beac18c65d 100644
--- a/glcpp/glcpp-parse.y
+++ b/glcpp/glcpp-parse.y
@@ -1312,7 +1312,7 @@ _glcpp_parser_expand_token_list (glcpp_parser_t *parser,
 				 token_list_t *list)
 {
 	token_node_t *node_prev;
-	token_node_t *node, *last;
+	token_node_t *node, *last = NULL;
 	token_list_t *expansion;
 
 	if (list == NULL)