From: Kenneth Graunke <kenneth@whitecape.org>
Date: Fri, 22 Nov 2013 11:38:26 +0000 (-0800)
Subject: glsl: Remove useless iteration through function parameters.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=c5adc1c8b554d3976b439ab344519847789c146b;p=mesa.git

glsl: Remove useless iteration through function parameters.

There's no need to loop through the "parameters" list and remove every
element; move_nodes_to(&parameters) already throws away all elements of
the destination list.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
---

diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp
index ffff2976aa4..3be7d51707a 100644
--- a/src/glsl/ir.cpp
+++ b/src/glsl/ir.cpp
@@ -1729,12 +1729,6 @@ ir_function_signature::replace_parameters(exec_list *new_params)
     * parameter information comes from the function prototype, it may either
     * specify incorrect parameter names or not have names at all.
     */
-   foreach_iter(exec_list_iterator, iter, parameters) {
-      assert(((ir_instruction *) iter.get())->as_variable() != NULL);
-
-      iter.remove();
-   }
-
    new_params->move_nodes_to(&parameters);
 }