From: Tom Stellard Date: Fri, 9 May 2014 01:05:02 +0000 (-0400) Subject: pipe-loader: Don't destroy the winsys in the sw loader X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=c650033b863c3ac8388ff1b192b476f63cf81202;p=mesa.git pipe-loader: Don't destroy the winsys in the sw loader The screen takes ownership of the winsys, and is responsible for destroying it. Users of pipe-loader should make sure they destory and screens they've created to avoid memory leaks. This fixes a crash in clover introduced by ce6c17c0833032e91a2d1b34f9eb80c738a854a2 where the pipe-loader was destroying the winsys while a screen was still using it. Cc: "10.2" Reviewed-by: Emil Velikov --- diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c index 08d43538efe..fa317f22aae 100644 --- a/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c @@ -145,9 +145,6 @@ pipe_loader_sw_release(struct pipe_loader_device **dev) { struct pipe_loader_sw_device *sdev = pipe_loader_sw_device(*dev); - if (sdev->ws && sdev->ws->destroy) - sdev->ws->destroy(sdev->ws); - if (sdev->lib) util_dl_close(sdev->lib);