From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 30 Dec 2015 06:49:53 +0000 (-0500)
Subject: sim: h8300: move unused/buggy lregs array
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=c78dff22918f29b3970729f32f70060b70e75678;p=binutils-gdb.git

sim: h8300: move unused/buggy lregs array

This array isn't used anywhere, and the init phase actually corrupts
some memory because the array has 18 elements but tries to set the
19th (ZERO) position.
---

diff --git a/sim/h8300/ChangeLog b/sim/h8300/ChangeLog
index b4ad754adfa..b293b29031c 100644
--- a/sim/h8300/ChangeLog
+++ b/sim/h8300/ChangeLog
@@ -1,3 +1,8 @@
+2015-12-30  Mike Frysinger  <vapier@gentoo.org>
+
+	* compile.c (lreg): Delete.
+	(init_pointers): Delete lreg assignments.
+
 2015-12-30  Mike Frysinger  <vapier@gentoo.org>
 
 	* inst.h: Delete file.
diff --git a/sim/h8300/compile.c b/sim/h8300/compile.c
index bc91725b699..beb2ab6b808 100644
--- a/sim/h8300/compile.c
+++ b/sim/h8300/compile.c
@@ -1251,7 +1251,6 @@ compile (SIM_DESC sd, int pc)
 
 static unsigned char  *breg[32];
 static unsigned short *wreg[16];
-static unsigned int   *lreg[18];
 
 #define GET_B_REG(X)     *(breg[X])
 #define SET_B_REG(X, Y) (*(breg[X])) = (Y)
@@ -1828,11 +1827,8 @@ init_pointers (SIM_DESC sd)
 	    sim_io_printf (sd, "init_pointers: internal error.\n");
 
 	  h8_set_reg (sd, i, 0);
-	  lreg[i] = h8_get_reg_buf (sd) + i;
 	}
 
-      /* Note: sim uses pseudo-register ZERO as a zero register.  */
-      lreg[ZERO_REGNUM] = h8_get_reg_buf (sd) + ZERO_REGNUM;
       init_pointers_needed = 0;
 
       /* Initialize the seg registers.  */