From: Jason Ekstrand Date: Thu, 18 Jan 2018 01:10:34 +0000 (-0800) Subject: anv/pipeline: Don't look at blend state unless we have an attachment X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=c8949e24984266cca3593291c30ea199baef5358;p=mesa.git anv/pipeline: Don't look at blend state unless we have an attachment Without this, we may end up dereferencing blend before we check for binding->index != UINT32_MAX. However, Vulkan allows the blend state to be NULL so long as you don't have any color attachments. This fixes a segfault when running The Talos Principal. Fixes: 12f4e00b69e724a23504b7bd3958fb75dc462950 Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Alex Smith Reviewed-by: Lionel Landwerlin --- diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 82fdf206a95..10efe542106 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/intel/vulkan/genX_pipeline.c @@ -1351,10 +1351,10 @@ has_color_buffer_write_enabled(const struct anv_pipeline *pipeline, if (binding->set != ANV_DESCRIPTOR_SET_COLOR_ATTACHMENTS) continue; - const VkPipelineColorBlendAttachmentState *a = - &blend->pAttachments[binding->index]; + if (binding->index == UINT32_MAX) + continue; - if (binding->index != UINT32_MAX && a->colorWriteMask != 0) + if (blend->pAttachments[binding->index].colorWriteMask != 0) return true; }