From: Simon Marchi Date: Thu, 12 Jan 2017 15:39:35 +0000 (-0500) Subject: Remove dead serial_interface_lookup calls X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ca1ca08b0893eb6ec530db0cc7e12537417244fa;p=binutils-gdb.git Remove dead serial_interface_lookup calls By inspecting the serial_add_interface calls, I found that the serial interface names that we have today are: - hardwire - terminal - pipe - tcp - event The calls to serial_interface_lookup with any other names are most likely leftovers which can be removed since these serial interfaces don't exist anymore. The commits that removed the "pc" and "parallel" interfaces are respectively: cb2a4ac5dae478fcd9d6e772530c3aba0576fc7a and e386d4d2fb55042f77d0557a0849ed2464aee7b3 gdb/ChangeLog: * serial.c (serial_open): Forget about "pc" and "lpt" serial interface. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 89bbb8fbaf7..153f6cd7df6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-01-12 Simon Marchi + + * serial.c (serial_open): Forget about "pc" and "lpt" serial interface. + 2017-01-11 Simon Marchi * cli/cli-decode.c (lookup_cmd_1): Fix typo in comment. diff --git a/gdb/serial.c b/gdb/serial.c index ac7c1b99c17..afb70758c60 100644 --- a/gdb/serial.c +++ b/gdb/serial.c @@ -209,11 +209,7 @@ serial_open (const char *name) const struct serial_ops *ops; const char *open_name = name; - if (strcmp (name, "pc") == 0) - ops = serial_interface_lookup ("pc"); - else if (startswith (name, "lpt")) - ops = serial_interface_lookup ("parallel"); - else if (startswith (name, "|")) + if (startswith (name, "|")) { ops = serial_interface_lookup ("pipe"); /* Discard ``|'' and any space before the command itself. */