From: Jason Ekstrand Date: Wed, 27 Feb 2019 06:12:01 +0000 (-0600) Subject: spirv: OpImageQueryLod requires a sampler X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ca295ddbfb414a526d3bab7daf93fffbbc417c6e;p=mesa.git spirv: OpImageQueryLod requires a sampler No idea how this fell through the cracks besides the fact that the sampler bound at 0 almost always works and the CTS isn't amazing. In any case, this appears to have been broken for almost forever. Reviewed-by: Samuel Iglesias Gonsálvez Reviewed-by: Lionel Landwerlin Cc: mesa-stable@lists.freedesktop.org --- diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index f5511587be8..de5e6cc8659 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -2154,6 +2154,7 @@ vtn_handle_texture(struct vtn_builder *b, SpvOp opcode, case nir_texop_txl: case nir_texop_txd: case nir_texop_tg4: + case nir_texop_lod: /* These operations require a sampler */ p->src = nir_src_for_ssa(&sampler->dest.ssa); p->src_type = nir_tex_src_sampler_deref; @@ -2162,7 +2163,6 @@ vtn_handle_texture(struct vtn_builder *b, SpvOp opcode, case nir_texop_txf: case nir_texop_txf_ms: case nir_texop_txs: - case nir_texop_lod: case nir_texop_query_levels: case nir_texop_texture_samples: case nir_texop_samples_identical: