From: Ville Syrjälä Date: Mon, 16 Jun 2014 17:54:32 +0000 (+0300) Subject: i915: Fix gen2 texblend setup X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ca55a1aaa78a79ed0bc4b2410d4a8b52ef05c5b2;p=mesa.git i915: Fix gen2 texblend setup Fix an off by one in the texture unit walk during texblend setup on gen2. This caused the last enabled texunit to be skipped resulting in totally messed up texturing. This is a regression introduced here: commit 1ad443ecdd694dd9bf3c4a5050d749fb80db6fa2 Author: Eric Anholt Date: Wed Apr 23 15:35:27 2014 -0700 i915: Redo texture unit walking on i830. Reviewed-by: Ian Romanick Cc: "10.2" Signed-off-by: Ville Syrjälä --- diff --git a/src/mesa/drivers/dri/i915/i830_texblend.c b/src/mesa/drivers/dri/i915/i830_texblend.c index 6e991c45774..236be59e239 100644 --- a/src/mesa/drivers/dri/i915/i830_texblend.c +++ b/src/mesa/drivers/dri/i915/i830_texblend.c @@ -445,7 +445,7 @@ i830EmitTextureBlend(struct i830_context *i830) I830_ACTIVESTATE(i830, I830_UPLOAD_TEXBLEND_ALL, false); if (ctx->Texture._MaxEnabledTexImageUnit != -1) { - for (unit = 0; unit < ctx->Texture._MaxEnabledTexImageUnit; unit++) + for (unit = 0; unit <= ctx->Texture._MaxEnabledTexImageUnit; unit++) if (ctx->Texture.Unit[unit]._Current) emit_texblend(i830, unit, blendunit++, unit == ctx->Texture._MaxEnabledTexImageUnit);