From: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat, 23 May 2015 07:03:53 +0000 (-0700)
Subject: glsl_compiler: Remove unused extra argument to printf in usage_fail
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=cb277cde6f2a210b0515cd04269964fd409307e9;p=mesa.git

glsl_compiler: Remove unused extra argument to printf in usage_fail

Flagged by Oracle's parfait static analyzer:

Error: Format string argument mismatch (CWE 628)
   In call to printf with format string "usage: %s [options] <file.vert | file.geom | file.frag>\n\nPossible options are:\n"
      Too many arguments for format string (got more than 1 arguments)
        at line 285 of src/glsl/main.cpp in function 'usage_fail'.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
---

diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp
index ccac8399646..4b39c9e54c2 100644
--- a/src/glsl/main.cpp
+++ b/src/glsl/main.cpp
@@ -282,7 +282,7 @@ usage_fail(const char *name)
       "usage: %s [options] <file.vert | file.geom | file.frag>\n"
       "\n"
       "Possible options are:\n";
-   printf(header, name, name);
+   printf(header, name);
    for (const struct option *o = compiler_opts; o->name != 0; ++o) {
       printf("    --%s\n", o->name);
    }