From: Ben Elliston <bje@au.ibm.com>
Date: Fri, 12 Jan 2007 00:39:10 +0000 (+0000)
Subject: 	* choose-temp.c (choose_temp_base): Check the result of the call
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=cc0732ba28d55b2bbcfe80617415379de4f4cc6c;p=binutils-gdb.git

	* choose-temp.c (choose_temp_base): Check the result of the call
	to mktemp rather than testing the length of the modified string.
---

diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index e72f84520d1..49afc151805 100644
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,8 @@
+2007-01-12  Ben Elliston  <bje@au.ibm.com>
+
+	* choose-temp.c (choose_temp_base): Check the result of the call
+	to mktemp rather than testing the length of the modified string.
+	
 2006-12-20  Geoffrey Keating  <geoffk@apple.com>
 
 	* cp-demangle.h: Add comment explaining what to do to avoid
diff --git a/libiberty/choose-temp.c b/libiberty/choose-temp.c
index 0cba9905d5b..4a26a827a2c 100644
--- a/libiberty/choose-temp.c
+++ b/libiberty/choose-temp.c
@@ -65,8 +65,7 @@ choose_temp_base (void)
   strcpy (temp_filename, base);
   strcpy (temp_filename + len, TEMP_FILE);
 
-  mktemp (temp_filename);
-  if (strlen (temp_filename) == 0)
+  if (mktemp (temp_filename) == 0)
     abort ();
   return temp_filename;
 }