From: Florent Kermarrec <florent@enjoy-digital.fr>
Date: Mon, 16 Sep 2019 15:02:55 +0000 (+0200)
Subject: soc/cores/spi: use new CSRField (no functional change)
X-Git-Tag: 24jan2021_ls180~1012
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=cca0478a5e57281224fd605078c9f2944ce9ef16;p=litex.git

soc/cores/spi: use new CSRField (no functional change)
---

diff --git a/litex/soc/cores/spi.py b/litex/soc/cores/spi.py
index b34fbf03..82288e95 100644
--- a/litex/soc/cores/spi.py
+++ b/litex/soc/cores/spi.py
@@ -10,11 +10,6 @@ from litex.soc.interconnect.csr import *
 
 # SPI Master ---------------------------------------------------------------------------------------
 
-SPI_CONTROL_START  = 0
-SPI_CONTROL_LENGTH = 8
-
-SPI_STATUS_DONE = 0
-
 class SPIMaster(Module, AutoCSR):
     """4-wire SPI Master
 
@@ -129,21 +124,24 @@ class SPIMaster(Module, AutoCSR):
             )
 
     def add_csr(self):
-        self._control  = CSRStorage(16)
-        self._status   = CSRStatus()
+        self._control  = CSRStorage(fields=[
+            CSRField("start",  size=1, offset=0, pulse=True),
+            CSRField("length", size=8, offset=8)])
+        self._status   = CSRStatus(fields=[
+            CSRField("done", size=1, offset=0)])
         self._mosi     = CSRStorage(self.data_width)
         self._miso     = CSRStatus(self.data_width)
         self._cs       = CSRStorage(len(self.cs), reset=1)
         self._loopback = CSRStorage()
 
         self.comb += [
-            self.start.eq(self._control.re & self._control.storage[SPI_CONTROL_START]),
-            self.length.eq(self._control.storage[SPI_CONTROL_LENGTH:]),
+            self.start.eq(self._control.fields.start),
+            self.length.eq(self._control.fields.length),
             self.mosi.eq(self._mosi.storage),
             self.cs.eq(self._cs.storage),
             self.loopback.eq(self._loopback.storage),
 
-            self._status.status[SPI_STATUS_DONE].eq(self.done),
+            self._status.fields.done.eq(self.done),
             self._miso.status.eq(self.miso),
         ]
 
diff --git a/litex/soc/interconnect/csr.py b/litex/soc/interconnect/csr.py
index 153997d0..e3d2f1ae 100644
--- a/litex/soc/interconnect/csr.py
+++ b/litex/soc/interconnect/csr.py
@@ -360,7 +360,7 @@ class CSRStorage(_CompoundCSR):
         for field in [*fields]:
             field_assign = getattr(self.fields, field.name).eq(self.storage[field.offset:field.offset + field.size])
             if field.pulse:
-                self.comb += If(self.storage.re, field_assign)
+                self.comb += If(self.re, field_assign)
             else:
                 self.comb += field_assign