From: Arnout Vandecappelle (Essensium/Mind) Date: Tue, 14 Feb 2012 09:56:52 +0000 (+0100) Subject: DOWNLOAD_WGET: use -O instead of -P to set output file X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=cf2486bf317e4bbf88c801fb96183ba62be78cc8;p=buildroot.git DOWNLOAD_WGET: use -O instead of -P to set output file Some URLs use url-encoded arguments to specify the file to download. Wget will then use an output file name which includes all the ampersands and such. However, this is not what we see from buildroot. E.g.: FOO_SITE="http://git.foo.com/?p=foo.git;a=blob;f=" FOO_SOURCE="foo.tgz" wget will download this into $(DL_DIR)/index.html?p=foo.git;a=blob;f=foo.tgz buildroot thinks it's in $(DL_DIR)/foo.tgz To make sure the view of wget and buildroot are consistent, specify the output file explicitly. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Peter Korsgaard --- diff --git a/package/Makefile.package.in b/package/Makefile.package.in index 33461b4dcb..ea44c6cef3 100644 --- a/package/Makefile.package.in +++ b/package/Makefile.package.in @@ -238,7 +238,7 @@ endef define DOWNLOAD_WGET test -e $(DL_DIR)/$(2) || \ - $(WGET) -P $(DL_DIR) $(call qstrip,$(1))/$(2) + $(WGET) -O $(DL_DIR)/$(2) $(call qstrip,$(1))/$(2) endef define SOURCE_CHECK_WGET