From: Brian Paul <brianp@vmware.com>
Date: Fri, 14 Aug 2009 17:27:51 +0000 (-0600)
Subject: Merge branch 'mesa_7_5_branch'
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d09a19bf6e09eb0c8908e9b5378962ac17bcbc4c;p=mesa.git

Merge branch 'mesa_7_5_branch'
---

d09a19bf6e09eb0c8908e9b5378962ac17bcbc4c
diff --cc src/mesa/main/dlist.c
index 4133f15dc72,74537d79e9b..9b68b3e1162
--- a/src/mesa/main/dlist.c
+++ b/src/mesa/main/dlist.c
@@@ -690,17 -688,40 +691,40 @@@ unpack_image(GLcontext *ctx, GLuint dim
               GLenum format, GLenum type, const GLvoid * pixels,
               const struct gl_pixelstore_attrib *unpack)
  {
 -   if (unpack->BufferObj->Name == 0) {
 +   if (!_mesa_is_bufferobj(unpack->BufferObj)) {
        /* no PBO */
-       return _mesa_unpack_image(dimensions, width, height, depth, format,
-                                 type, pixels, unpack);
+       GLvoid *image = _mesa_unpack_image(dimensions, width, height, depth,
+                                          format, type, pixels, unpack);
+       if (pixels && !image) {
+          _mesa_error(ctx, GL_OUT_OF_MEMORY, "display list construction");
+       }
+       return image;
     }
-    else
-       if (_mesa_validate_pbo_access
-           (dimensions, unpack, width, height, depth, format, type, pixels)) {
-       const GLubyte *src = ADD_POINTERS(unpack->BufferObj->Data, pixels);
-       return _mesa_unpack_image(dimensions, width, height, depth, format,
-                                 type, src, unpack);
+    else if (_mesa_validate_pbo_access(dimensions, unpack, width, height, depth,
+                                       format, type, pixels)) {
+       const GLubyte *map, *src;
+       GLvoid *image;
+ 
+       map = (GLubyte *)
+          ctx->Driver.MapBuffer(ctx, GL_PIXEL_UNPACK_BUFFER_EXT,
+                                GL_READ_ONLY_ARB, unpack->BufferObj);
+       if (!map) {
+          /* unable to map src buffer! */
+          _mesa_error(ctx, GL_INVALID_OPERATION, "unable to map PBO");
+          return NULL;
+       }
+ 
+       src = ADD_POINTERS(map, pixels);
+       image = _mesa_unpack_image(dimensions, width, height, depth,
+                                  format, type, src, unpack);
+ 
+       ctx->Driver.UnmapBuffer(ctx, GL_PIXEL_UNPACK_BUFFER_EXT,
+                               unpack->BufferObj);
+ 
+       if (!image) {
+          _mesa_error(ctx, GL_OUT_OF_MEMORY, "display list construction");
+       }
+       return image;
     }
     /* bad access! */
     return NULL;