From: Sagar Ghuge Date: Wed, 24 Oct 2018 20:27:27 +0000 (-0700) Subject: intel/compiler: Print hex representation along with floating point value X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d15fa248605ca5c44f042a80a670088a83fb33fe;p=mesa.git intel/compiler: Print hex representation along with floating point value While encoding the immediate floating point values in instruction we use values upto precision 9, but while disassembling, we print precision to 6 places, which round up the value and gives wrong interpretation for encoded immediate constant. To avoid misinterpretation of encoded immediate values in instruction and disassembled output, print hex representation along with floating point value which can be used by assembler in future. Signed-off-by: Sagar Ghuge Reviewed-by: Samuel Iglesias Gonsálvez --- diff --git a/src/intel/compiler/brw_disasm.c b/src/intel/compiler/brw_disasm.c index 322f4544dfd..6a7e988641a 100644 --- a/src/intel/compiler/brw_disasm.c +++ b/src/intel/compiler/brw_disasm.c @@ -1283,7 +1283,9 @@ imm(FILE *file, const struct gen_device_info *devinfo, enum brw_reg_type type, format(file, "0x%08xUV", brw_inst_imm_ud(devinfo, inst)); break; case BRW_REGISTER_TYPE_VF: - format(file, "[%-gF, %-gF, %-gF, %-gF]VF", + format(file, "0x%"PRIx64"VF", brw_inst_bits(inst, 127, 96)); + pad(file, 48); + format(file, "/* [%-gF, %-gF, %-gF, %-gF]VF */", brw_vf_to_float(brw_inst_imm_ud(devinfo, inst)), brw_vf_to_float(brw_inst_imm_ud(devinfo, inst) >> 8), brw_vf_to_float(brw_inst_imm_ud(devinfo, inst) >> 16), @@ -1293,10 +1295,14 @@ imm(FILE *file, const struct gen_device_info *devinfo, enum brw_reg_type type, format(file, "0x%08xV", brw_inst_imm_ud(devinfo, inst)); break; case BRW_REGISTER_TYPE_F: - format(file, "%-gF", brw_inst_imm_f(devinfo, inst)); + format(file, "0x%"PRIx64"F", brw_inst_bits(inst, 127, 96)); + pad(file, 48); + format(file, " /* %-gF */", brw_inst_imm_f(devinfo, inst)); break; case BRW_REGISTER_TYPE_DF: - format(file, "%-gDF", brw_inst_imm_df(devinfo, inst)); + format(file, "0x%016"PRIx64"DF", brw_inst_bits(inst, 127, 64)); + pad(file, 48); + format(file, "/* %-gDF */", brw_inst_imm_df(devinfo, inst)); break; case BRW_REGISTER_TYPE_HF: string(file, "Half Float IMM");